1496823 - Remove some unneeded code in nsChildView.mm

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, enhancement, P2)

Description

[Markus Stange [:mstange]]

Over the years, nsChildView.mm has accumulated some cruft related to painting. We've gone through many different ways to get pixels on the screen, and the code still expects to handle some of them even though they're no longer used. I'm planning to clean that up a bit.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1496823 - Remove setNeedsPendingDisplay infrastructure. r?spohl

Many years ago, Gecko would sometimes call nsChildView::Invalidate during drawRect:.
This is no longer the case: Widget invalidations now only happen outside of drawRect,
usually from a refresh tick or from viewWillDraw.

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1496823 - Remove EventThreadRunner and the pref that enabled it. r?kats

This was an experiment before we had e10s. It's no longer needed.

Depends on D7922

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1496823 - Remove -[ChildView isUsingMainThreadOpenGL] and dependent code because it always returns NO. r?spohl

The main thread layer manager is always NONE, BASIC or CLIENT. It is never OPENGL anymore.
Main-thread OpenGL rendering was removed in bug 924403.

Depends on D7924

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1496823 - Remove -[ChildView setNeedsDisplayInRect:] override. r?spohl

This override was intended to ignore unnecessary nsChildView::Invalidate calls
when using main thread OpenGL. With OMTC, Gecko no longer calls Invalidate in
those cases, it just composites on the compositor thread, and the widget's main
thread code doesn't really hear about it. So this workaround is no longer necessary.

Depends on D7925

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1496823 - Remove unneeded debugging code. r?spohl

I don't think anybody has made use of this code in years.

Depends on D7927

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1496823 - Inline drawUsingOpenGL into drawRect:inContext: and tweak a comment. r?spohl

Depends on D7928

Comment 7

[Markus Stange [:mstange]]

Attachment: Bug 1496823 - Inline -[ChildView drawRect:inContext:] into -[ChildView drawRect:]. r?spohl

This was separate because at some point in the past we were calling
-[ChildView drawRect:inContext:] from a separate draw-in-titlebar pass. That separate
pass was removed in bug 676241.

Depends on D7929

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1496823 - Remove declaration of -[NSView _regionForOpaqueDescendants:forMove:]. r?spohl

Our implementation of this method was removed in bug 1070710. I forgot to remove the declaration in that bug.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34f52a304c52
Remove setNeedsPendingDisplay infrastructure. r=spohl
https://hg.mozilla.org/integration/autoland/rev/959084361b15
Remove EventThreadRunner and the pref that enabled it. r=kats,spohl
https://hg.mozilla.org/integration/autoland/rev/8848453f27af
Remove -[ChildView isUsingMainThreadOpenGL] and dependent code because it always returns NO. r=spohl
https://hg.mozilla.org/integration/autoland/rev/56dc11bab861
Remove -[ChildView setNeedsDisplayInRect:] override. r=spohl
https://hg.mozilla.org/integration/autoland/rev/d1d878123a68
Remove unneeded debugging code. r=spohl
https://hg.mozilla.org/integration/autoland/rev/408b8733a0a6
Inline drawUsingOpenGL into drawRect:inContext: and tweak a comment. r=spohl
https://hg.mozilla.org/integration/autoland/rev/c9da89f17cf9
Inline -[ChildView drawRect:inContext:] into -[ChildView drawRect:]. r=spohl

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/34f52a304c52
https://hg.mozilla.org/mozilla-central/rev/959084361b15
https://hg.mozilla.org/mozilla-central/rev/8848453f27af
https://hg.mozilla.org/mozilla-central/rev/56dc11bab861
https://hg.mozilla.org/mozilla-central/rev/d1d878123a68
https://hg.mozilla.org/mozilla-central/rev/408b8733a0a6
https://hg.mozilla.org/mozilla-central/rev/c9da89f17cf9

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/075201afc029
Remove declaration of -[NSView _regionForOpaqueDescendants:forMove:]. r=spohl

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/075201afc029