Closed Bug 1496844 Opened 3 years ago Closed 1 year ago

treatment of https view-source URIs is inconsistent

Categories

(Firefox :: Site Identity, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 79
Tracking Status
firefox79 --- fixed

People

(Reporter: keeler, Assigned: jawad)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The site identity treatment of https view-source URIs seems either broken or inconsistent to me. If you visit e.g. view-source:https://example.com, the location bar will not have a lock icon, but if you open the site identity panel, it will say "Secure Connection".

However this goes, we should add some tests to make sure we don't unintentionally change whatever behavior we decide is correct.
Priority: -- → P3
Duplicate of this bug: 1519723
Flags: needinfo?(jhofmann)
Flags: needinfo?(dkeeler)

Since this is the open bug, please associate that patch with this one instead of that one.

Flags: needinfo?(dkeeler)

(In reply to Dana Keeler (she/her) (use needinfo) (:keeler for reviews) from comment #3)

Since this is the open bug, please associate that patch with this one instead of that one.

Done. Thank you!

Flags: needinfo?(dkeeler)
Assignee: nobody → ijawadak
Flags: needinfo?(dkeeler)
Priority: P3 → P1
Flags: needinfo?(jhofmann)
Attachment #9050463 - Attachment description: Bug 1496844 - view-source https page missing secure indicator in address bar. r=johannh → Bug 1496844 - treatment of https view-source URIs is inconsistent. r=johannh
Status: NEW → ASSIGNED
Blocks: 1534757

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:jawad, could you have a look please?

Flags: needinfo?(ijawadak)
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/791dcf072a98
treatment of https view-source URIs is inconsistent. r=johannh

Backed out changeset 791dcf072a98 (Bug 1496844) for browser_identity_UI.js failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=mochitest-browser-chrome-e10s%2C%28bc7%29&fromchange=ca68ded1df00ba9848076b8b9db98e04f6bcd51b&tochange=3245e485822f8681ec8cacdc49d761f01efd74b9&selectedJob=245243877

Backout link: https://hg.mozilla.org/integration/autoland/rev/3245e485822f8681ec8cacdc49d761f01efd74b9

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245243877&repo=autoland&lineNumber=2105

01:01:38 INFO - TEST-START | browser/base/content/test/siteIdentity/browser_identity_UI.js
01:01:39 INFO - TEST-INFO | started process screencapture
01:01:39 INFO - TEST-INFO | screencapture: exit 0
01:01:39 INFO - Buffered messages logged at 01:01:38
01:01:39 INFO - Entering test bound test
01:01:39 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identity_UI.js | gIdentityHandler should exist -
01:01:39 INFO - Running test #0 (normal domain)
01:01:39 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identity_UI.js | Control Center is hidden -
01:01:39 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identity_UI.js | location matches for test #0 (normal domain) -
01:01:39 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identity_UI.js | effectiveHost matches for test #0 (normal domain) -
01:01:39 INFO - Waiting for the Control Center to be shown
01:01:39 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identity_UI.js | Control Center is visible -
01:01:39 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identity_UI.js | identity UI header shows the host for test #0 (normal domain) -
01:01:39 INFO - Buffered messages logged at 01:01:39
01:01:39 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identity_UI.js | security subview header shows the host for test #0 (normal domain) -
01:01:39 INFO - Running test #1 (view-source)
01:01:39 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identity_UI.js | Control Center is hidden -
01:01:39 INFO - Buffered messages finished
01:01:39 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteIdentity/browser_identity_UI.js | location matches for test #1 (view-source) - Got http://example.com/, expected view-source:http://example.com/
01:01:39 INFO - Stack trace:
01:01:39 INFO - chrome://mochikit/content/browser-test.js:test_is:1325
01:01:39 INFO - chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_identity_UI.js:runTest:90
01:01:39 INFO - chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_identity_UI.js:test:56
01:01:39 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
01:01:39 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
01:01:39 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
01:01:39 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
01:01:39 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identity_UI.js | mode matched -
01:01:39 INFO - Waiting for the Control Center to be shown
01:01:39 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identity_UI.js | Control Center is visible -
01:01:39 INFO - Not taking screenshot here: see the one that was previously logged
01:01:39 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteIdentity/browser_identity_UI.js | identity UI header shows the host for test #1 (view-source) -
01:01:39 INFO - Stack trace:
01:01:39 INFO - chrome://mochikit/content/browser-test.js:test_ok:1314
01:01:39 INFO - chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_identity_UI.js:runTest:107
01:01:39 INFO - chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_identity_UI.js:test:56
01:01:39 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
01:01:39 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
01:01:39 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
01:01:39 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
01:01:39 INFO - Not taking screenshot here: see the one that was previously logged
01:01:39 INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/siteIdentity/browser_identity_UI.js | security subview header shows the host for test #1 (view-source) -
01:01:39 INFO - Stack trace:
01:01:39 INFO - chrome://mochikit/content/browser-test.js:test_ok:1314
01:01:39 INFO - chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_identity_UI.js:runTest:117
01:01:39 INFO - chrome://mochitests/content/browser/browser/base/content/test/siteIdentity/browser_identity_UI.js:test:56
01:01:39 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1116
01:01:39 INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1144
01:01:39 INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1005
01:01:39 INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:803
01:01:39 INFO - Running test #2 (normal HTTPS)
01:01:39 INFO - TEST-PASS | browser/base/content/test/siteIdentity/browser_identity_UI.js | Control Center is hidden -
...

Duplicate of this bug: 1573433
See Also: → 1574660

@ Jawad Ahmed [:jawad] - I'm unassigning you from this bug per inactivity, so other person could be working on this. But feel free to work on it again, if this bug will be still unassigned.

Assignee: ijawadak → nobody
Status: ASSIGNED → NEW

We just need to fix up the test here...

Flags: needinfo?(jhofmann)
Assignee: nobody → ijawadak
Status: NEW → ASSIGNED
Pushed by jhofmann@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/655e0b63e61e
treatment of https view-source URIs is inconsistent. r=johannh
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 79
Flags: needinfo?(jhofmann)
Flags: needinfo?(ijawadak)
You need to log in before you can comment on or make changes to this bug.