Closed
Bug 1497099
Opened 6 years ago
Closed 6 years ago
[remote-dbg-next] Use common PropTypes in React components
Categories
(DevTools :: about:debugging, enhancement, P1)
DevTools
about:debugging
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: daisuke, Assigned: daisuke)
References
Details
Attachments
(1 file, 3 obsolete files)
Currently, we define PropTypes in React components respectively. Therefore, if the kind of datas that are sent from reducer has changed, all components that refer need to reflect. Also, a concern of consistency with reducer remains. To resolve this, manage PropTypes in one place, the each components refer there. e.g. https://searchfox.org/mozilla-central/source/devtools/client/inspector/fonts/types.js
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → dakatsuka
Status: NEW → ASSIGNED
Priority: P2 → P1
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
Depends on D8693
Assignee | ||
Comment 3•6 years ago
|
||
Depends on D8694
Assignee | ||
Comment 4•6 years ago
|
||
As we discussed on slack, we will go forward step by step. Firstly, we define `runtime` object. Then if needed, address next one.
Updated•6 years ago
|
Attachment #9017084 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9017083 -
Attachment is obsolete: true
Updated•6 years ago
|
Attachment #9017082 -
Attachment is obsolete: true
Assignee | ||
Comment 5•6 years ago
|
||
Pushed by dakatsuka@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32cff4bae820 Use common runtime PropTypes. r=jdescottes
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/32cff4bae820
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•