Closed
Bug 1497110
Opened 6 years ago
Closed 6 years ago
remove currencySystem from PaymentRequest
Categories
(Core :: DOM: Web Payments, enhancement, P1)
Core
DOM: Web Payments
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: marcosc, Assigned: marcosc)
References
(Blocks 1 open bug, )
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
|
1.67 KB,
patch
|
edenchuang
:
review+
peterv
:
superreview+
|
Details | Diff | Splinter Review |
Was removed from spec
|
Assignee | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #9015176 -
Flags: review?(echuang) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
|
||
Comment 3•6 years ago
|
||
Hi, i tried to land this but got: https://irccloud.mozilla.com/file/SFv4HzTX/image.png please ask again for a review from someone in that list.
Thank you.
Flags: needinfo?(mcaceres)
Keywords: checkin-needed
|
|
Assignee | |
Comment 5•6 years ago
|
||
Comment on attachment 9015176 [details] [diff] [review]
Remove currencyCode and related check
Review of attachment 9015176 [details] [diff] [review]:
-----------------------------------------------------------------
Baku, need IDL review. Could you set it back to "checkin-needed" after, please.
Attachment #9015176 -
Flags: superreview?(amarchesini)
|
|
Assignee | |
Comment 6•6 years ago
|
||
Marion, could you kindly see about getting Eden and I added to the DOM Peers list (see comment 3)? We've been part of DOM Team for literally years (I think I'm coming up to 6 years!), so seems a little odd that we are not on the list.
If we need to do something special to get on the list, could you let us know?
Flags: needinfo?(mdaly)
|
|
Assignee | |
Comment 8•6 years ago
|
||
Comment on attachment 9015176 [details] [diff] [review]
Remove currencyCode and related check
Review of attachment 9015176 [details] [diff] [review]:
-----------------------------------------------------------------
Peter, could you please review/approve the IDL? We've been waiting now a week for simple IDL reviews - please see also my email about changing this process. Having to wait a week is frankly unacceptable.
Attachment #9015176 -
Flags: superreview?(amarchesini) → superreview?(peterv)
|
||
Updated•6 years ago
|
Attachment #9015176 -
Flags: superreview?(peterv) → superreview+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26d29ab41cdf
remove currencySystem from PaymentRequest. r=edenchuang, peterv
Keywords: checkin-needed
|
||
Comment 10•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
||
Updated•6 years ago
|
Keywords: dev-doc-needed
|
||
Comment 11•6 years ago
|
||
Documentation updates are finished. Please advise if there any issues outstanding with the PaymentCurrencyAmount dictionary related content. Work on the rest of Payment Request documentation is ongoing.
New pages:
* https://developer.mozilla.org/en-US/docs/Web/API/PaymentCurrencyAmount
* https://developer.mozilla.org/en-US/docs/Web/API/PaymentCurrencyAmount/value
* https://developer.mozilla.org/en-US/docs/Web/API/PaymentCurrencyAmount/currency
* https://developer.mozilla.org/en-US/docs/Web/API/PaymentCurrencyAmount/currencySystem
Updated pages:
* https://developer.mozilla.org/en-US/docs/Web/API/Payment_Request_API
PR submitted for BCD updates: https://github.com/mdn/browser-compat-data/pull/3096
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•