Closed Bug 1497110 Opened 1 year ago Closed 1 year ago

remove currencySystem from PaymentRequest

Categories

(Core :: DOM: Web Payments, enhancement, P1, trivial)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

(Blocks 1 open bug, )

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Was removed from spec
Severity: normal → trivial
Priority: -- → P1
Assignee: nobody → mcaceres
Status: NEW → ASSIGNED
Attachment #9015176 - Flags: review?(echuang)
Attachment #9015176 - Flags: review?(echuang) → review+
Keywords: checkin-needed
Hi, i tried to land this but got: https://irccloud.mozilla.com/file/SFv4HzTX/image.png please ask again for a review from someone in that list. 

Thank you.
Flags: needinfo?(mcaceres)
Keywords: checkin-needed
Oopsy! forgot about that.
Flags: needinfo?(mcaceres)
Comment on attachment 9015176 [details] [diff] [review]
Remove currencyCode and related check

Review of attachment 9015176 [details] [diff] [review]:
-----------------------------------------------------------------

Baku, need IDL review. Could you set it back to "checkin-needed" after, please.
Attachment #9015176 - Flags: superreview?(amarchesini)
Marion, could you kindly see about getting Eden and I added to the DOM Peers list (see comment 3)? We've been part of DOM Team for literally years (I think I'm coming up to 6 years!), so seems a little odd that we are not on the list. 

If we need to do something special to get on the list, could you let us know?
Flags: needinfo?(mdaly)
ok
Flags: needinfo?(mdaly)
Comment on attachment 9015176 [details] [diff] [review]
Remove currencyCode and related check

Review of attachment 9015176 [details] [diff] [review]:
-----------------------------------------------------------------

Peter, could you please review/approve the IDL? We've been waiting now a week for simple IDL reviews - please see also my email about changing this process. Having to wait a week is frankly unacceptable.
Attachment #9015176 - Flags: superreview?(amarchesini) → superreview?(peterv)
Attachment #9015176 - Flags: superreview?(peterv) → superreview+
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/26d29ab41cdf
remove currencySystem from PaymentRequest. r=edenchuang, peterv
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/26d29ab41cdf
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.