Closed Bug 1497111 Opened 2 years ago Closed 2 years ago

Remove unnecessarily null'ed out values of PaymentRequest.webidl

Categories

(Core :: DOM: Web Payments, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: marcosc, Assigned: edenchuang)

References

Details

(Keywords: dev-doc-complete, Whiteboard: [webpayments-reserve])

Attachments

(1 file, 2 obsolete files)

No description provided.
Blocks: 1493860
No longer blocks: 1368949
Priority: -- → P2
Whiteboard: [webpayments-reserve]
Assignee: nobody → echuang
Attachment #9024475 - Flags: review?(amarchesini)
Status: NEW → ASSIGNED
Priority: P2 → P1
Comment on attachment 9024475 [details] [diff] [review]
Remove unnecessarily null'ed out values of PaymentRequest.webidl

Review of attachment 9024475 [details] [diff] [review]:
-----------------------------------------------------------------

All good. Can you also update:
https://searchfox.org/mozilla-central/rev/7f7c353e969e61a6a85201cc8ad3c3de12ac30d8/dom/webidl/PaymentRequest.webidl#7

replacing the TR URL with: https://w3c.github.io/payment-request/#idl-index
Attachment #9024475 - Flags: review?(amarchesini) → review+
> replacing the TR URL with: https://w3c.github.io/payment-request/#idl-index

Oh, if possible, please point to the section where the IDL is defined. Makes it a little quicker to look stuff up.
Update the patch according to comment 2 and comment 3.
Attachment #9024475 - Attachment is obsolete: true
Attachment #9024714 - Flags: review+
Keywords: checkin-needed
Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ee2e7c7fa16
Remove unnecessarily null'ed out values of PaymentRequest.webidl. r=baku
Keywords: checkin-needed
Flags: qe-verify-
Update expected results on web-platform tests.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0d329f39a74905b069b909aa96f308c845feb5f
Attachment #9024714 - Attachment is obsolete: true
Flags: needinfo?(echuang)
Attachment #9024901 - Flags: review+
Keywords: checkin-needed
Pushed by rgurzau@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c4d4368566b4
Remove unnecessarily null'ed out values of PaymentRequest.webidl. r=baku
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c4d4368566b4
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Check that we have these syntaxes listed correctly in the docs.
Keywords: dev-doc-needed
This has been addressed throughout during handling of other doc updates.
You need to log in before you can comment on or make changes to this bug.