Closed
Bug 1497111
Opened 6 years ago
Closed 6 years ago
Remove unnecessarily null'ed out values of PaymentRequest.webidl
Categories
(Core :: DOM: Web Payments, enhancement, P1)
Core
DOM: Web Payments
Tracking
()
RESOLVED
FIXED
mozilla65
| Tracking | Status | |
|---|---|---|
| firefox65 | --- | fixed |
People
(Reporter: marcosc, Assigned: edenchuang)
References
Details
(Keywords: dev-doc-complete, Whiteboard: [webpayments-reserve])
Attachments
(1 file, 2 obsolete files)
|
12.62 KB,
patch
|
edenchuang
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•6 years ago
|
|
||
Updated•6 years ago
|
Priority: -- → P2
|
|
Reporter | |
Updated•6 years ago
|
Whiteboard: [webpayments-reserve]
|
Assignee | |
Comment 1•6 years ago
|
||
Assignee: nobody → echuang
Attachment #9024475 -
Flags: review?(amarchesini)
|
||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Priority: P2 → P1
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9024475 [details] [diff] [review] Remove unnecessarily null'ed out values of PaymentRequest.webidl Review of attachment 9024475 [details] [diff] [review]: ----------------------------------------------------------------- All good. Can you also update: https://searchfox.org/mozilla-central/rev/7f7c353e969e61a6a85201cc8ad3c3de12ac30d8/dom/webidl/PaymentRequest.webidl#7 replacing the TR URL with: https://w3c.github.io/payment-request/#idl-index
Attachment #9024475 -
Flags: review?(amarchesini) → review+
|
|
Reporter | |
Comment 3•6 years ago
|
||
> replacing the TR URL with: https://w3c.github.io/payment-request/#idl-index
Oh, if possible, please point to the section where the IDL is defined. Makes it a little quicker to look stuff up.|
|
Assignee | |
Comment 4•6 years ago
|
||
Update the patch according to comment 2 and comment 3.
Attachment #9024475 -
Attachment is obsolete: true
Attachment #9024714 -
Flags: review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by nerli@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/9ee2e7c7fa16 Remove unnecessarily null'ed out values of PaymentRequest.webidl. r=baku
Keywords: checkin-needed
|
||
Comment 6•6 years ago
|
||
Backed out changeset 9ee2e7c7fa16 (Bug 1497111) for wpt failures on payment-request-constructor.https.html. Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/9629f8d432bfb6c0c0a159ae4eed4de9d1a4534d Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=9ee2e7c7fa1622e929ac237a76bf6fe55e4cdc28&selectedJob=211432195 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=211432195&repo=mozilla-inbound&lineNumber=7690
Flags: needinfo?(echuang)
|
|
||
Updated•6 years ago
|
Flags: qe-verify-
|
|
Assignee | |
Comment 7•6 years ago
|
||
Update expected results on web-platform tests. https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0d329f39a74905b069b909aa96f308c845feb5f
Attachment #9024714 -
Attachment is obsolete: true
Flags: needinfo?(echuang)
Attachment #9024901 -
Flags: review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by rgurzau@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c4d4368566b4 Remove unnecessarily null'ed out values of PaymentRequest.webidl. r=baku
Keywords: checkin-needed
|
||
Comment 9•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c4d4368566b4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
|
||
Comment 10•6 years ago
|
||
Check that we have these syntaxes listed correctly in the docs.
Keywords: dev-doc-needed
|
||
Comment 11•6 years ago
|
||
This has been addressed throughout during handling of other doc updates.
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•