Closed Bug 1497144 Opened Last year Closed Last year

Convert DocShellCapabilities.jsm and ScrollPosition.jsm to C++

Categories

(Firefox :: Session Restore, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox65 --- fixed

People

(Reporter: alchen, Assigned: alchen)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Before doing bug 1474130, I would like to rewrite the js modules which are used in ContentSessionStore.jsm.

In this bug, I will focus on DocShellCapabilities.jsm and ScrollPosition.jsm.
Assignee: nobody → alchen
Status: NEW → ASSIGNED
Blocks: 1474130
Small wishlist item: It would be nice if the resolution saving code used on mobile [1][2] could be integrated into this as well. But since that currently isn't part of ScrollPosition.jsm and Desktop currently doesn't do pinch zooming, either, feel free to ignore my request for now.

[1] https://dxr.mozilla.org/mozilla-central/rev/90853a59691e0c77014c38049bfb38b2b6ca1e16/mobile/android/components/SessionStore.js#938-947
[2] https://dxr.mozilla.org/mozilla-central/rev/90853a59691e0c77014c38049bfb38b2b6ca1e16/mobile/android/chrome/geckoview/GeckoViewContent.js#91-108
Actively being worked on, so triaged as P1.
Priority: -- → P1
Get rid of DocShellCapabilities.jsm and ScrollPosition.jsm
Depends on: 1498892
Depends on: 1498812
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b7afb9ada5e
Rewrite DocShellCapabilities.jsm and ScrollPosition.jsm into C++ r=nika
https://hg.mozilla.org/integration/autoland/rev/50d03049245a
part 2 - Get rid of ScrollPosition.jsm r=JanH,nika
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/5b7afb9ada5e
https://hg.mozilla.org/mozilla-central/rev/50d03049245a
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Blocks: 1564412
You need to log in before you can comment on or make changes to this bug.