1497163 - [wpt-sync] Sync PR 13388 - [LayoutNG] Correct LayoutText::LinesBoundingBox() for vertical-rl.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 13388 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13388
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:
>  [LayoutNG] Correct LayoutText::LinesBoundingBox() for vertical-rl.
>  
>  NG needs to produce a rectangle with the block-axis offset relatively to
>  block-start of the container, just like legacy does. Using purely
>  physical coordinates is wrong.
>  
>  This fixes issues with scroll anchoring, and possibly other things too.
>  
>  One test had to be rebaselined, due to a rounding change.
>  LayoutText::DebugRect() calls LinesBoundingBox(), which now flips the
>  block-axis coordinate for vertical-rl. This affects rounding of the
>  size of the rectangle.
>  
>  Bug: 889449
>  Change-Id: I7053ed7fe05ce443f53a128660d60f27fea7f8b3
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  Reviewed-on: https://chromium-review.googlesource.com/1264596
>  WPT-Export-Revision: 76bb3d9fbcda83cf1ef02663cd9c7dece58680ba

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=a52839a13684a79b5c4646fc1560c45078211967

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=1ae070129e766f43bac15a3f96f890c4ba081069

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6495311149609fa86ad8613e1e44711fc296e74

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Ran 1 tests and 1 subtests
OK     : 1
FAIL   : 1

New tests that have failures or other problems:
/css/css-scroll-anchoring/text-anchor-in-vertical-rl.html
    Line at edge of scrollport shouldn't jump visually when content is inserted before: FAIL

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1b374a8deaf
[wpt PR 13388] - [LayoutNG] Correct LayoutText::LinesBoundingBox() for vertical-rl., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/5fcb3470239e
[wpt PR 13388] - Update wpt metadata, a=testonly

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c1b374a8deaf
https://hg.mozilla.org/mozilla-central/rev/5fcb3470239e