1497187 - Hide the flexbox container properties in the flex item accordion

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P2)

Description

[Patrick Brosset <:pbro>]

When displaying the outline and sizing info for a flex item, the flexbox container properties are of very little value. We should hide them there.

Comment 1

[Patrick Brosset <:pbro>]

Attachment: Screen Shot 2018-10-08 at 15.16.48.png

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1497187.patch [1.0]

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 9015986 [details] [diff] [review]
1497187.patch [1.0]

Review of attachment 9015986 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/client/themes/layout.css
@@ +122,5 @@
>   * Flex Item List
>   */
>  
> +.flex-header + .flex-item-list {
> +  border-top: 1px solid var(--theme-splitter-color);

As much as possible, I'd like us to use css logic properties consistently. So here: `border-block-start`

@@ +164,5 @@
>   * Flex Item Sizing Outline
>   */
>  
>  .flex-outline-container {
> +  border-top: 1px solid var(--theme-splitter-color);

same here

@@ +350,5 @@
>   * Flex Container Properties
>   */
>  
>  #flex-container-properties {
> +  border-top: 1px solid var(--theme-splitter-color);

and here

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e7a4e6283a41
Hide the flexbox container properties in the flex item accordion. r=pbro

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e7a4e6283a41