14972 - Toolbar popup menu hover

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Michael Lowe]

Popup menus on the toolbar should be drawn with the same outline hover style as
plain toolbar buttons.   At present popup menus on the toolbar don't display any
hover style when you mouse over them.

Comment 1

[Peter Trudelle]

reassigning to hangas per hyatt, can you verify this is still happening with the
new UI?

Comment 2

[Michael Lowe]

This bug can be fixed by adding these rules to skin.css:

toolbar > menu:hover > titledbutton {
  border: 1px outset white;
  color:#333366;
  text-decoration: underline;
}

toolbar > menu[open=true] > titledbutton {
  border: 1px inset white;
}

Comment 3

[hangas]

Including German to help understand what needs to be done here.  I suspect that
the new skin handles the hover case in a different way.

Comment 4

[german]

we just landed the new skins. Is your problem still there?
+ G

Comment 5

[Michael Lowe]

Yes, the problem is still there but my suggested fix will need to be modified
for the new skin style.   Have a look at the Composer.   On the toolbar, moving
the mouse over the Font or Size popup menus on the toolbar does not display the
same feedback as the other buttons on the toolbar.   Also, opening the popup
menu should display the same open feedback as what normal menus have.   This is
what this change aims to fix.

Comment 6

[hangas]

German, we should talk this over and make sure we agree on a default behavior for
menus in toolbars.

Comment 7

[hangas]

Moving to M12.

Comment 8

[german]

I think the problem is that in the new skin the buttons need to be assigned both
classes "push" and "popup" in order to get the proper behavior, such like class=
"push popup". This might solve the problem

Comment 9

[Phil Peterson]

Is this a beta stopper?

Comment 10

[Phil Peterson]

M16

Comment 11

[hangas]

Sending to Ben.

Comment 12

[Ben Goodger (use ben at mozilla dot org for email)]

looks fixed to me. 

Comment 13

[sairuh (rarely reading bugmail)]

toolbar stuff -> claudius.

Comment 14

[Claudius Gayle]

VERIFIED with 2000032809 builds on all platforms