Closed Bug 1497252 Opened 11 months ago Closed 10 months ago

TRR: Add telemetry to count how often a full DoH RTT is "wasted" in trr-first

Categories

(Core :: Networking: DNS, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: bagder, Assigned: bagder)

Details

(Whiteboard: [necko-triaged][trr])

Attachments

(2 files)

The new probe would count (in trr-first mode) how often a DoH request is made that fails only to have a subsequent native resolve work. Ie how often is the successful resolve delayed by a preceeding TRR failure.
How often is a successful (native) resolve delayed by a preceeding TRR
failure.

MozReview-Commit-ID: Da8oH53CZTs
(In reply to Daniel Stenberg [:bagder] from comment #0)
> The new probe would count (in trr-first mode) how often a DoH request is
> made that fails only to have a subsequent native resolve work. Ie how often
> is the successful resolve delayed by a preceeding TRR failure.

Can you actually extend DNS_TRR_FIRST. So that we see a comparison between different situations: trr_worked, trr_failed_native_called_and_native_succeeded, trr_failed_native_called_and_native_failed, trr_not_used.
Flags: needinfo?(daniel)
We can't extend categories, but we can create a new and remove the old.
Flags: needinfo?(daniel)
Attachment #9015440 - Attachment is obsolete: true
Summary: TRR: Add telemetry DNS_TRR_ONERTT_DELAYED to count how often a full DoH RTT is "wasted" in trr-first → TRR: Add telemetry to count how often a full DoH RTT is "wasted" in trr-first
Attachment #9015440 - Attachment is obsolete: false
Comment on attachment 9016574 [details]
Request for data collection review: Telemetry::DNS_TRR_FIRST2

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, Daniel Stenberg.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1

5) Is the data collection request for default-on or default-off?

Default ON, all channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, permanent.
Attachment #9016574 - Flags: review?(francois) → review+
Attachment #9015440 - Attachment description: bug 1497252 - Add DNS_TRR_ONERTT_DELAYED, count latency "waste" → bug 1497252 - Add DNS_TRR_FIRST2, with an added category
Pushed by daniel@haxx.se:
https://hg.mozilla.org/integration/autoland/rev/8d8ed5f447d0
Add DNS_TRR_FIRST2, with an added category r=dragana
https://hg.mozilla.org/mozilla-central/rev/8d8ed5f447d0
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.