Closed Bug 1497319 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 13359 - [LayoutNG] Correct LayoutText::Quads() for vertical-rl.

Categories

(Core :: DOM: CSS Object Model, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13359 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13359
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  [LayoutNG] Correct LayoutText::Quads() for vertical-rl.
>  
>  NG needs to produce a rectangle with the block-axis offset relatively to
>  block-start of the container, just like legacy does. Using purely
>  physical coordinates is wrong.
>  
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  Change-Id: I9989628dcc339c71d850818498538aafa142ed29
>  Reviewed-on: https://chromium-review.googlesource.com/c/1261698
>  Reviewed-by: Koji Ishii \<kojii@chromium.org>
>  Commit-Queue: Morten Stenshorne \<mstensho@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#596747}
>
Component: web-platform-tests → DOM: CSS Object Model
Product: Testing → Core
Ran 6 tests and 6 subtests
OK     : 6
PASS   : 3
FAIL   : 3

New tests that have failures or other problems:
/css/cssom-view/getClientRects-br-htb-rtl.html
    Position of the BR element: FAIL
/css/cssom-view/getClientRects-br-vlr-rtl.html
    Position of the BR element: FAIL
/css/cssom-view/getClientRects-br-vrl-rtl.html
    Position of the BR element: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c524ed4f7f2
[wpt PR 13359] - [LayoutNG] Correct LayoutText::Quads() for vertical-rl., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/3fc8243dfd23
[wpt PR 13359] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/7c524ed4f7f2
https://hg.mozilla.org/mozilla-central/rev/3fc8243dfd23
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.