Closed
Bug 1497379
Opened 6 years ago
Closed 6 years ago
Enable OSVR on BSDs
Categories
(Core :: WebVR, enhancement)
Core
WebVR
Tracking
()
RESOLVED
FIXED
mozilla64
People
(Reporter: jbeich, Assigned: jbeich)
References
Details
Attachments
(1 file)
|
10.55 KB,
patch
|
kip
:
review+
|
Details | Diff | Splinter Review |
OSVR doesn't need upstream patches, and someone confirmed it works, at least, outside of Firefox. If it breaks again in future we may want to disable building the whole file like Android did. https://www.reddit.com/r/openbsd_gaming/comments/89vxf9/vr_demo_on_openbsd_via_openhmd_with_osvr_hdk2/
Does it make sense at this time? https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd557c5ec859755e78e573749927a5f9fef41293 https://searchfox.org/mozilla-central/rev/29aea2a2a3bd/gfx/vr/service/moz.build#7-8
Attachment #9015432 -
Flags: review?(kgilbert)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9015432 [details] [diff] [review] v0 This LGTM, thanks! I'm glad we can have fewer platform specific #ifdef's
Attachment #9015432 -
Flags: review?(kgilbert) → review+
Keywords: checkin-needed
|
||
Updated•6 years ago
|
Assignee: nobody → jbeich
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/dfe25ffb4ad2 Don't disable OSVR along with OpenVR on BSDs. r=kip
Keywords: checkin-needed
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dfe25ffb4ad2
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
|
|
||
Updated•6 years ago
|
status-firefox62:
--- → unaffected
status-firefox63:
--- → wontfix
status-firefox-esr60:
--- → unaffected
Oops, regression keyword is mistaken. OSVR was limited to Tier1 even before bug 1375693. Backport to earlier branches isn't required because OSVR is disabled by default (bug 1299972) and Firefox < 63 requires rebasing before bug 1466701.
Keywords: regression
Summary: Enable OSVR again on BSDs → Enable OSVR on BSDs
You need to log in
before you can comment on or make changes to this bug.
Description
•