1497408 - Make NS_MACPREFERENCESREADER_CID unique

Status: RESOLVED FIXED

(Firefox :: Enterprise Policies, enhancement, P1)

Description

[Haik Aftandilian [:haik]]

The CID for nsMacPreferencesReader (NS_MACPREFERENCESREADER_CID in nsMacPreferencesReader.h) ended up being the same as nsOSPermissionRequestBase (NS_OSPERMISSIONREQUEST_CID from nsOSPermissionRequestBase.h). This prevents JS createInstance(Ci.nsIOSPermissionRequest) calls from working.

Comment 1

[Haik Aftandilian [:haik]]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=26c2332804fa36590f13206a1a5c767cc27ab5ac

Comment 2

[Haik Aftandilian [:haik]]

Attachment: Bug 1497408 - Make NS_MACPREFERENCESREADER_CID unique r?spohl

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72189fd7d7b2
Make NS_MACPREFERENCESREADER_CID unique r=spohl

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/72189fd7d7b2

Comment 5

[Liz Henry (:lizzard) (relman/hg->git project)]

Does this affect 63? Is it something that we may want to uplift before 63 release?

Comment 6

[Haik Aftandilian [:haik]]

I should have explained this in the description, but it was introduced by bug 1445943 and only needs to be uplifted if bug 1445943 is uplifted.

Comment 7

[Pascal Chevrel:pascalc (PTO until Sept 2)]

(In reply to Haik Aftandilian [:haik] from comment #6)
> I should have explained this in the description, but it was introduced by
> bug 1445943 and only needs to be uplifted if bug 1445943 is uplifted.

Enterprise policy support for MacOS is a 64 feature, we won't uplift it, so this bug should not be uplifted to 63.