1497431 - Implement `PushSubscription::expirationTime`

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, enhancement, P3)

Description

[Lina Butler (ex-Mozilla)]

http://w3c.github.io/push-api/#pushsubscription-interface

It's a `DOMTimeStamp?`, so we can just report it as `null` for now. I don't think we have fixed expiration times for subscriptions on the server; it depends on how frequently Firefox connects, and whether the router record still exists.

Comment 1

[marcos]

Attachment: Implement PushManager.prototype.expirationTime + toJSON()

Adds expirationTime to PushManager, which uses EpochTimeStamp. See https://github.com/w3c/push-api/pull/338

Comment 2

[marcos]

Depends on https://bugzilla.mozilla.org/show_bug.cgi?id=1735098

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf7cc00c8be4
Implement PushManager.prototype.expirationTime + toJSON() r=mt,peterv

Comment 4

[Norisz Fay [:noriszfay]]

Backed out for causing build bustages on PushSubscription.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/f4c58475e2d3a7575c6d517853071b94c2cb7b16
Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=bOm1N3TQRn6aunP0pyDhlQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=cf7cc00c8be4d8143ad7d1cb8a7af8002c4b37c2
Failure log: https://treeherder.mozilla.org/logviewer?job_id=358292264&repo=autoland&lineNumber=35453

Comment 5

[marcos]

On it! thanks.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/acd50e43590e
Implement PushManager.prototype.expirationTime + toJSON() r=mt,peterv

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/acd50e43590e