soft reminder notifications for all events
Categories
(Calendar :: General, enhancement)
Tracking
(thunderbird_esr78 wontfix, thunderbird91 fixed)
People
(Reporter: mkmelin, Assigned: rnons)
References
(Blocks 1 open bug)
Details
Attachments
(7 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
65.59 KB,
image/png
|
Paenglab
:
feedback+
darktrojan
:
feedback+
|
Details |
58.79 KB,
image/png
|
Details | |
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-beta+
|
Details | Review |
Comment 1•7 years ago
|
||
Reporter | ||
Comment 2•7 years ago
|
||
Reporter | ||
Updated•7 years ago
|
Comment 3•7 years ago
|
||
Comment 4•7 years ago
|
||
Comment 5•7 years ago
|
||
Reporter | ||
Updated•4 years ago
|
Assignee | ||
Comment 6•4 years ago
|
||
Add calendar.alarms.shownotification pref, the idea is to allow user choose to use reminder dialog or notification, or both.
Assignee | ||
Updated•4 years ago
|
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/bdbff1173b00
Initial step to support soft reminder in CalAlarmService. r=darktrojan
Assignee | ||
Comment 8•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/d6b4520234c1
Support calendar level notification settings. r=darktrojan
Assignee | ||
Comment 10•4 years ago
|
||
This patch introduces a <calendar-notifications-setting> element, then use it in prefs page for global setting, and in calendar-properties-dialog for calendar level setting.
Updated•4 years ago
|
Comment 11•4 years ago
|
||
Comment on attachment 9217943 [details]
Bug 1497434 - Add config UI for global and calendar level notifications. r=darktrojan,aleca
Thanks for the request, I'm adding some comments in phab.
Updated•4 years ago
|
Assignee | ||
Comment 12•4 years ago
|
||
Redefine the calendar.notifications.times pref:
- use
END:
to mean relative to the end - use comma as separator of entries
An example is PT2M,END:-PT3M
.
Assignee | ||
Updated•4 years ago
|
Comment 13•4 years ago
|
||
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/4cfd23620218
Support calendar notification times relative to both start and end. r=darktrojan
Updated•4 years ago
|
Updated•4 years ago
|
Comment 14•4 years ago
|
||
Lots of UI elements for a small dialogs, but maybe with this organization we can make it more digestible.
I suggest to drop the Notifications:
label as we're not in need of respecting the form label: input
structure for this.
Let's visually separate this section with a bolder title and a description to better guide the user.
Add
and Global pref
should be at the bottom on the opposite sides.
It's okay having the Add
button at the bottom since we can safely assume users won't need to set up 20+ notifications for a calendar.
The created notification could be indented, with the delete
button having a flat style to not overwhelm the UI.
With the extra space we should force the longer dropdown to expand to the full available width so we can potentially avoid truncated text.
With this organization we could potentially even add a checkbox to toggle ON and OFF a specific notification, but I'm not sure it's necessary as it's probably quicker to delete and recreate it if necessary as we don't have that many options.
Assignee | ||
Comment 15•4 years ago
|
||
Comment on attachment 9230003 [details]
calendar-dialog-notifications.png
What about the preference page, do you want the Add Notifcation
button to be on the same line as "Manage notification for upcoming..."?
Comment 16•4 years ago
|
||
What about the preference page, do you want the Add Notifcation button to be on the same line as "Manage notification for upcoming..."?
No, the preferences page looks good as it is, other than the -
icon which should also be replaced with the trash can.
Comment 17•4 years ago
|
||
Comment on attachment 9230003 [details]
calendar-dialog-notifications.png
This looks good for me.
Reporter | ||
Comment 18•4 years ago
|
||
Comment on attachment 9230003 [details]
calendar-dialog-notifications.png
I like what's in phab
Updated•4 years ago
|
Assignee | ||
Updated•4 years ago
|
Comment 19•4 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/4802db6b7d41
Add config UI for global and calendar level notifications. r=darktrojan,aleca
![]() |
||
Comment 20•4 years ago
|
||
The patch [contains a typo}(https://hg.mozilla.org/comm-central/rev/4802db6b7d41#l10.11):
calendar-notifications-label = Show notifcations for upcoming events
Could you push a follow-up, please?
Comment 21•4 years ago
|
||
Reporter | ||
Updated•4 years ago
|
Comment 22•4 years ago
|
||
I stumbled upon a couple of issue on macOS in daily.
- The icon of the "remove notification" button in the global preferences is not centered aligned.
- When clicking on "Global notifications preference" inside a Calendar properties dialog, the preferences tab is opened but it loads the previously opened section (general, compose, etc) and it doesn't properly focus on the correct calendar notification section.
Also, the properties dialog remains opened above everything else.
Comment 23•4 years ago
|
||
I see both on Windows too.
Assignee | ||
Comment 24•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Comment 25•4 years ago
|
||
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/f9a21ec59e73
Fix remove button style in calendar notification setting. r=aleca,darktrojan
Assignee | ||
Comment 26•4 years ago
|
||
Comment on attachment 9232066 [details]
Bug 1497434 - Fix remove button style in calendar notification setting. r=aleca,darktrojan
[Approval Request Comment]
A style fix to the remove button and change calendar-properties-dialog to be non-modal. Low risk.
Comment 27•4 years ago
|
||
Comment on attachment 9232066 [details]
Bug 1497434 - Fix remove button style in calendar notification setting. r=aleca,darktrojan
[Triage Comment]
Approved for beta
Comment 28•4 years ago
|
||
bugherder uplift |
Thunderbird 91.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/c2c8ee7a63ff
Description
•