1497434 - soft reminder notifications for all events

Status: RESOLVED FIXED

(Calendar :: General, enhancement)

Description

[Magnus Melin [:mkmelin]]

[Thought I'd filed this in the past, but apparently not.]

I would like to get a (native) notification for each event in my calendar. When I have a meeting, notify me 5 min in advance, and then again 1 min before. If the meeting has a link, let me just click it open right from there. Times ideally  configurable, per event category.

This is different from the reminder feature because that is far too aggressive. I just want a soft reminder that I'll see while I'm at the computer - to be handled at discretion.

Comment 1

[[:MakeMyDay]]

Can you specify what a (native) notification would look like for you? Using an OS notification?

What link are you referring to (an URL property, an ATTACH property, an uri in the event description or summary)?

Comment 2

[Magnus Melin [:mkmelin]]

Well, native depends on the platform, what I was more thinking of was using the Notifications API (https://developer.mozilla.org/en-US/docs/Web/API/notification) and then let that handle out how to integrate with platform.

I'm not sure exactly which properties e.g. video calls should be in and which they are in for real. I suppose the URL is correct yes. But, that's for the details. The most important thing for me personally would be to get the gentle nudge in the first place.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pretty sure we had a bug on this back some time ago with a patch but for some reason we decided against it. May be time to revisit it. I'm pretty sure ssitter was involved, maybe he remembers?

Comment 4

[Stefan Sitter [:ssitter]]

Maybe you thought of Bug 329676 that I created 12 years ago?

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Yes, that's the one! Thanks for the link.

Comment 6

[Ping Chen [:rnons] (away)]

Attachment: Bug 1497434 - Initial step to support soft reminder in CalAlarmService. r=darktrojan

Add calendar.alarms.shownotification pref, the idea is to allow user choose to use reminder dialog or notification, or both.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/bdbff1173b00
Initial step to support soft reminder in CalAlarmService. r=darktrojan

Comment 8

[Ping Chen [:rnons] (away)]

Attachment: Bug 1497434 - Support calendar level notification settings. r=darktrojan

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d6b4520234c1
Support calendar level notification settings. r=darktrojan

Comment 10

[Ping Chen [:rnons] (away)]

Attachment: Bug 1497434 - Add config UI for global and calendar level notifications. r=darktrojan,aleca

This patch introduces a <calendar-notifications-setting> element, then use it in prefs page for global setting, and in calendar-properties-dialog for calendar level setting.

Comment 11

[Alessandro Castellani [:aleca]]

Comment on attachment 9217943 [details]
Bug 1497434 - Add config UI for global and calendar level notifications. r=darktrojan,aleca

Thanks for the request, I'm adding some comments in phab.

Comment 12

[Ping Chen [:rnons] (away)]

Attachment: Bug 1497434 - Support calendar notification times relative to both start and end. r=darktrojan

Redefine the calendar.notifications.times pref:

• use END: to mean relative to the end
• use comma as separator of entries

An example is PT2M,END:-PT3M.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4cfd23620218
Support calendar notification times relative to both start and end. r=darktrojan

Comment 14

[Alessandro Castellani [:aleca]]

Attachment: calendar-dialog-notifications.png

Lots of UI elements for a small dialogs, but maybe with this organization we can make it more digestible.

I suggest to drop the Notifications: label as we're not in need of respecting the form label: input structure for this.
Let's visually separate this section with a bolder title and a description to better guide the user.

Add and Global pref should be at the bottom on the opposite sides.
It's okay having the Add button at the bottom since we can safely assume users won't need to set up 20+ notifications for a calendar.

The created notification could be indented, with the delete button having a flat style to not overwhelm the UI.
With the extra space we should force the longer dropdown to expand to the full available width so we can potentially avoid truncated text.

With this organization we could potentially even add a checkbox to toggle ON and OFF a specific notification, but I'm not sure it's necessary as it's probably quicker to delete and recreate it if necessary as we don't have that many options.

Comment 15

[Ping Chen [:rnons] (away)]

Comment on attachment 9230003 [details]
calendar-dialog-notifications.png

What about the preference page, do you want the Add Notifcation button to be on the same line as "Manage notification for upcoming..."?

Comment 16

[Alessandro Castellani [:aleca]]

What about the preference page, do you want the Add Notifcation button to be on the same line as "Manage notification for upcoming..."?

No, the preferences page looks good as it is, other than the - icon which should also be replaced with the trash can.

Comment 17

[Richard Marti (:Paenglab)]

Comment on attachment 9230003 [details]
calendar-dialog-notifications.png

This looks good for me.

Comment 18

[Magnus Melin [:mkmelin]]

Comment on attachment 9230003 [details]
calendar-dialog-notifications.png

I like what's in phab

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4802db6b7d41
Add config UI for global and calendar level notifications. r=darktrojan,aleca

Comment 20

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The patch [contains a typo}(https://hg.mozilla.org/comm-central/rev/4802db6b7d41#l10.11):
calendar-notifications-label = Show notifcations for upcoming events

Could you push a follow-up, please?

Comment 21

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4635a5424b50
follow-up to fix typo. rs=me

Comment 22

[Alessandro Castellani [:aleca]]

Attachment: Screen Shot 2021-07-19 at 11.28.02 AM.png

I stumbled upon a couple of issue on macOS in daily.

1. The icon of the "remove notification" button in the global preferences is not centered aligned.
2. When clicking on "Global notifications preference" inside a Calendar properties dialog, the preferences tab is opened but it loads the previously opened section (general, compose, etc) and it doesn't properly focus on the correct calendar notification section.
   Also, the properties dialog remains opened above everything else.

Comment 23

[Richard Marti (:Paenglab)]

I see both on Windows too.

Comment 24

[Ping Chen [:rnons] (away)]

Attachment: Bug 1497434 - Fix remove button style in calendar notification setting. r=aleca,darktrojan

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f9a21ec59e73
Fix remove button style in calendar notification setting. r=aleca,darktrojan

Comment 26

[Ping Chen [:rnons] (away)]

Comment on attachment 9232066 [details]
Bug 1497434 - Fix remove button style in calendar notification setting. r=aleca,darktrojan

[Approval Request Comment]
A style fix to the remove button and change calendar-properties-dialog to be non-modal. Low risk.

Comment 27

[Wayne Mery (:wsmwk)]

Comment on attachment 9232066 [details]
Bug 1497434 - Fix remove button style in calendar notification setting. r=aleca,darktrojan

[Triage Comment]
Approved for beta

Comment 28

[Rob Lemley [:rjl]]

Thunderbird 91.0b5:
https://hg.mozilla.org/releases/comm-beta/rev/c2c8ee7a63ff