1497476 - Remove nsITransferable.kFlavorHasDataProvider

Status: RESOLVED FIXED

(Core :: Widget, enhancement)

Description

[Tom S. (please needinfo tschuster)]

kFlavorHasDataProvider (= 0) is saved as a special value for length in transferables. That is incompatible with my plan of removing the length completely. We can just try QI'ing to nsIFlavorDataProvider instead, because there is only implementation: nsContentAreaDragDropDataProvider

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1497476 - Clang-format nsTransferable.cpp. r?karlt

Running clang-format makes this code at least a bit more pleasant to look at.

Comment 2

[Tom S. (please needinfo tschuster)]

Attachment: Bug 1497476 - Remove nsITransferable.kFlavorHasDataProvider. r?karlt

Depends on D8074

Comment 3

[Tom S. (please needinfo tschuster)]

Comment on attachment 9015484 [details]
Bug 1497476 - Clang-format nsTransferable.cpp. r?karlt

Maybe those requests don't show up on phabricator somehow?

Comment 4

[Markus Stange [:mstange]]

Ouch, I hadn't noticed that the Bugzilla dashboard had stopped showing a list of Phabricator review requests and now only shows a  link to the list instead. I missed a bunch of reviews that way.

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/507a9e5aaeea

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1e4e5029ffb
Remove nsITransferable.kFlavorHasDataProvider. r=NeilDeakin

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d1e4e5029ffb