Remove nsITransferable.kFlavorHasDataProvider

RESOLVED FIXED in Firefox 64

Status

()

enhancement
RESOLVED FIXED
8 months ago
7 months ago

People

(Reporter: evilpie, Assigned: evilpie)

Tracking

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed, firefox65 fixed)

Details

Attachments

(2 attachments)

Assignee

Description

8 months ago
kFlavorHasDataProvider (= 0) is saved as a special value for length in transferables. That is incompatible with my plan of removing the length completely. We can just try QI'ing to nsIFlavorDataProvider instead, because there is only implementation: nsContentAreaDragDropDataProvider
Assignee

Updated

8 months ago
Assignee: nobody → evilpies
Assignee

Comment 1

8 months ago
Running clang-format makes this code at least a bit more pleasant to look at.
Depends on: 1497779
Assignee

Comment 3

7 months ago
Comment on attachment 9015484 [details]
Bug 1497476 - Clang-format nsTransferable.cpp. r?karlt

Maybe those requests don't show up on phabricator somehow?
Attachment #9015484 - Flags: review?(mstange)
Assignee

Updated

7 months ago
Attachment #9015485 - Flags: review?(enndeakin)
Ouch, I hadn't noticed that the Bugzilla dashboard had stopped showing a list of Phabricator review requests and now only shows a  link to the list instead. I missed a bunch of reviews that way.

Updated

7 months ago
Attachment #9015485 - Flags: review?(enndeakin) → review+
Assignee

Updated

7 months ago
Blocks: 1499821
Assignee

Updated

7 months ago
Attachment #9015484 - Flags: review?(mstange)

Comment 5

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/507a9e5aaeea
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Assignee

Updated

7 months ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Comment 6

7 months ago
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d1e4e5029ffb
Remove nsITransferable.kFlavorHasDataProvider. r=NeilDeakin
https://hg.mozilla.org/mozilla-central/rev/d1e4e5029ffb
Status: REOPENED → RESOLVED
Last Resolved: 7 months ago7 months ago
Resolution: --- → FIXED
Target Milestone: mozilla64 → mozilla65
You need to log in before you can comment on or make changes to this bug.