Closed Bug 1497476 Opened 2 years ago Closed 2 years ago

Remove nsITransferable.kFlavorHasDataProvider

Categories

(Core :: Widget, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox64 --- fixed
firefox65 --- fixed

People

(Reporter: evilpie, Assigned: evilpie)

References

Details

Attachments

(2 files)

kFlavorHasDataProvider (= 0) is saved as a special value for length in transferables. That is incompatible with my plan of removing the length completely. We can just try QI'ing to nsIFlavorDataProvider instead, because there is only implementation: nsContentAreaDragDropDataProvider
Assignee: nobody → evilpies
Running clang-format makes this code at least a bit more pleasant to look at.
Depends on: 1497779
Comment on attachment 9015484 [details]
Bug 1497476 - Clang-format nsTransferable.cpp. r?karlt

Maybe those requests don't show up on phabricator somehow?
Attachment #9015484 - Flags: review?(mstange)
Attachment #9015485 - Flags: review?(enndeakin)
Ouch, I hadn't noticed that the Bugzilla dashboard had stopped showing a list of Phabricator review requests and now only shows a  link to the list instead. I missed a bunch of reviews that way.
Attachment #9015485 - Flags: review?(enndeakin) → review+
Blocks: 1499821
Attachment #9015484 - Flags: review?(mstange)
https://hg.mozilla.org/mozilla-central/rev/507a9e5aaeea
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by evilpies@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d1e4e5029ffb
Remove nsITransferable.kFlavorHasDataProvider. r=NeilDeakin
https://hg.mozilla.org/mozilla-central/rev/d1e4e5029ffb
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: mozilla64 → mozilla65
You need to log in before you can comment on or make changes to this bug.