Closed
Bug 1497477
Opened 6 years ago
Closed 6 years ago
Stop running other tests in rusttest builds
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1505072
People
(Reporter: ted, Unassigned)
References
(Blocks 1 open bug)
Details
While investigating bug 1396845 I triggered a lot of rusttest builds on try pushes. I would hit occasional intermittent failures on things like the xpcshell selftests, which makes me realize that we probably shouldn't be running all of those tests on rusttest builds. We already run the rest of `make check` on normal builds, rusttest builds shouldn't waste time on those.
There are a few ways we could go about this. The most straightforward might be to add a new mozharness action that just runs the Rust tests, and then change the rusttest mozharness configs to use that and not `check-test`:
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/scripts/fx_desktop_build.py#35-44
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/configs/builds/releng_sub_linux_configs/32_rusttests.py#7
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/configs/builds/releng_sub_linux_configs/32_rusttests_debug.py#7
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/configs/builds/releng_sub_linux_configs/64_rusttests.py#7
https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mozharness/configs/builds/releng_sub_linux_configs/64_rusttests_debug.py#7
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/builds/taskcluster_sub_win32/rusttests_opt.py
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/configs/builds/taskcluster_sub_win64/rusttests_opt.py
Reporter | ||
Comment 1•6 years ago
|
||
I think the simplest way to fix this would be to make something like `mach test rusttests` work, add a mozharness step to run that instead, and then change the rusttest mozharness configs to run that step instead of check-test.
Comment 2•6 years ago
|
||
Assuming it sticks, bug 1505072 will take care of this.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•