Fix indentation in discardBrowser

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P3
normal
RESOLVED FIXED
7 months ago
6 months ago

People

(Reporter: dao, Assigned: andrewjgregoryajg, Mentored)

Tracking

({good-first-bug})

Trunk
Firefox 64
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox64 fixed)

Details

(Whiteboard: [lang=js])

Attachments

(2 attachments)

(Assignee)

Comment 1

7 months ago
I'd love to take this on as my first contribution - how do I actually edit the file in question?
(Reporter)

Comment 2

7 months ago
(In reply to andrewjgregoryajg from comment #1)
> I'd love to take this on as my first contribution - how do I actually edit
> the file in question?

Do you have the source code yet? See https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code
(Assignee)

Comment 3

7 months ago
(In reply to Dão Gottwald [::dao] from comment #2)
> (In reply to andrewjgregoryajg from comment #1)
> > I'd love to take this on as my first contribution - how do I actually edit
> > the file in question?
> 
> Do you have the source code yet? See
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code

That link is very helpful, thanks! I am going through it right now and will let you know if I have any other questions.
(Reporter)

Comment 6

6 months ago
Could you please combine both commits into one?
(Assignee)

Comment 7

6 months ago
Do you mean combine these two attachments or combine the two commits here: https://phabricator.services.mozilla.com/D8559 into one?
(Reporter)

Comment 8

6 months ago
I mean the two phabricator commits...

Comment 9

6 months ago
(In reply to Dão Gottwald [::dao] from comment #8)
> I mean the two phabricator commits...

I would like to work on this issue if @andrewjgregoryajg is not doing this.
(Assignee)

Comment 10

6 months ago
I am still working on this but I have yet to figure out how to combine two Phabricator commits. I've read the Phabricator docs and couldn't find anything. Can anyone point me in the right direction?
(Reporter)

Comment 11

6 months ago
Maybe just discard the previous commits and create a completely new one.
(Reporter)

Comment 12

6 months ago
I now accepted your patch removing tabbrowser.js' last line since it's not a big deal.

Comment 13

6 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/745dab0eb011
Fix indentation in discardBrowser r=dao
(Reporter)

Updated

6 months ago
Assignee: nobody → andrewjgregoryajg

Comment 14

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/745dab0eb011
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Flags: qe-verify-
(Assignee)

Comment 15

6 months ago
Thanks for being patient. I am still trying to get the hang of all of these new tools (Phabricator, Mercurial, etc) so I appreciate the time you've taken to respond here.
You need to log in before you can comment on or make changes to this bug.