These conditions of the if-clause lack two spaces of indentation: https://searchfox.org/mozilla-central/rev/29aea2a2a3bd0f5e25ce0b60a76053fb25ba5149/browser/base/content/tabbrowser.js#2117-2122
I'd love to take this on as my first contribution - how do I actually edit the file in question?
(In reply to andrewjgregoryajg from comment #1) > I'd love to take this on as my first contribution - how do I actually edit > the file in question? Do you have the source code yet? See https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code
(In reply to Dão Gottwald [::dao] from comment #2) > (In reply to andrewjgregoryajg from comment #1) > > I'd love to take this on as my first contribution - how do I actually edit > > the file in question? > > Do you have the source code yet? See > https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Source_Code That link is very helpful, thanks! I am going through it right now and will let you know if I have any other questions.
Could you please combine both commits into one?
Do you mean combine these two attachments or combine the two commits here: https://phabricator.services.mozilla.com/D8559 into one?
I mean the two phabricator commits...
(In reply to Dão Gottwald [::dao] from comment #8) > I mean the two phabricator commits... I would like to work on this issue if @andrewjgregoryajg is not doing this.
I am still working on this but I have yet to figure out how to combine two Phabricator commits. I've read the Phabricator docs and couldn't find anything. Can anyone point me in the right direction?
Maybe just discard the previous commits and create a completely new one.
I now accepted your patch removing tabbrowser.js' last line since it's not a big deal.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/745dab0eb011 Fix indentation in discardBrowser r=dao
Thanks for being patient. I am still trying to get the hang of all of these new tools (Phabricator, Mercurial, etc) so I appreciate the time you've taken to respond here.
You need to log in before you can comment on or make changes to this bug.