1497507 - The value proposition statement from the "Recommended by Pocket" area is no longer aligned with the "CTA" button after it is wrapped to the second line

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P3)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:
- Firefox 64.0a1 Build ID - 20181008220129

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Prerequisites]:
- Have a new Firefox profile.
- Have the following prefs in the "about:config" page:
	- "browser.newtabpage.activity-stream.pocketCta" set to "{"cta_button":"","cta_text":"","cta_url":"","use_cta":true}";
	- "browser.search.region" set to "US".

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Open a new tab and move the browser on 1/4 of the screen.
3. Observe the behavior.

[Expected result]:
- The value proposition statement is aligned with the "CTA" button.

[Actual result]:
- The value proposition statement is not in line with the "CTA" button.

[Notes]:
- Attached a screen recording of the issue.

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4539

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/4e9f6058fa176c94fbb90b865a430bda6ad8851d
Bug 1497507 - aligning cta w. value proposition (#4539)

* Bug 1497507 - aligning cta w. value proposition

* fixups

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/9fce755a1262

Comment 4

[Ed Lee :Mardak]

Bug 1505929 comment 4 backout link: https://hg.mozilla.org/mozilla-central/rev/4efd19ac076280abf1365b0bb7fd2018ce162b38

Comment 5

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/a46fe158e566

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Does this need a Beta uplift request?

Comment 7

[Gavin Suntop [:gvn] (they/them)]

Nope! Thanks!

Comment 8

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible on the latest Nightly 65.0a1 (Build ID 20181120220133) on Windows 10, Mac 10.13, and Arch Linux 4.16.