1497524 - Tapping on the text of ::after content with :active::before doesn't trigger click event

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P2)

Description

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

This is filed as a follow-up of bug 1473108.

We should consider the case that the tap happens on the text of ::after or ::before, will attach a test soon.

Comment 1

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

Attachment: test.html

Comment 2

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Edgar Chen [:edgar] from comment #1)
> Created attachment 9015539 [details]
> test.html

(Note this is only reproducible on Fennec)

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Bug 1089326 might fix this.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(Just fixing last couple of tests for that)

Comment 5

[Edgar Chen [:edgar] (Parental leave until Oct. 09.)]

(In reply to Olli Pettay [:smaug] from comment #3)
> Bug 1089326 might fix this.

I could not reproduce on Fennec anymore after applying the latest patch in bug 1089326.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

I just wrote a fix for this while investigating bug 1501774, hopefully you don't mind Edgar :)

We can wait for the button fix instead, though the test should probably be landed regardless.

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1497524 - Properly dispatch events when the NAC event target is not the root, and it gets reframed.

We can wait for the button fix if you want, but it was easy enough to fix, I
think.

I think we could merge NativeAnonymousContentRemoved with the walk that
NotifyFrameRemoved does, since the content should still be in the tree when that
happens. If you want, I can do that as a followup.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f3db4de7859
Properly dispatch events when the NAC event target is not the root, and it gets reframed. r=smaug

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/3f3db4de7859

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Do we need to backport this to Beta or can it ride the trains?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9022459 [details]
Bug 1497524 - Properly dispatch events when the NAC event target is not the root, and it gets reframed.

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: None

User impact if declined: Some click events and such won't get dispatched if you click on generated content.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: (I don't think manual testing is needed, but testing the STR of bug 1501774 or so would work in case someone else decides it is)

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Minor fixup to the patch from bug 1473108.

String changes made/needed: none

Comment 13

[Emilio Cobos Álvarez (:emilio)]

I think it can ride the trains, but given it's early in the cycle it may be worth to land it on beta so it rides the trains together with bug 1473108.

Comment 14

[Julien Cristau [:jcristau]]

Comment on attachment 9022459 [details]
Bug 1497524 - Properly dispatch events when the NAC event target is not the root, and it gets reframed.

I'd rather punt this to 65 based on bug 1504980.