1497528 - Large SVG in google docs clipped incorrectly with WebRender

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Nicolas Silva [:nical]]

With WebRender, zooming on the svg at https://docs.google.com/drawings/d/1zPNU69MVr3wOnKFa5_G4apeCFBhxCVKNxo5l0AEmyIk/edit (either using google doc's zoom tool at the top left or the browser's zoom), the right side of the svg gets clipped out.
The bug doesn't happen without WebRender.

Comment 1

[Nicolas Silva [:nical]]

The bug doesn't happen with the same SVG file outside of google docs.

Comment 2

[Paul Adenot (:padenot)]

Attachment: expected

Comment 3

[Paul Adenot (:padenot)]

Attachment: actual

This is on OSX but I can repro on Linux as well.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: Standalone test case

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Attachment: Reduced test case

Comment 6

[Bobby Holley (:bholley)]

I've seen this on lots of google slide decks. Only happens for me when the window is stretched beyond 3300px or so (I can't reproduce this unless I plug my external monitor into my MBP, taking my horizontal resolution from 2880 to 3840).

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Attachment: Even more reduced

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Simply translating the rounded rectangle to left makes it draw so it seems like this has something to do with being far to the right

Comment 9

[Emilio Cobos Álvarez (:emilio)]

In case it helps, I only see the bug on a HiDPI screen, not on a normal one.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

So it's looking a bit like this is not a blob image bug. The whole image is painted and appears to be there in the capture. It's just clipped when webrender draws it. I'm going to try to reduce the wr-capture and see where that gets me.

Comment 11

[Jeff Muizelaar [:jrmuizel]]

So it looks like this is a problem with precision. Reducing the scale of the coordinates in a wr-capture makes things draw properly. This suggests that it's unrelated to blob invalidation.

I'm passing it over to Glenn for now.

Comment 12

[Glenn Watson [:gw]]

A fix is here - https://github.com/servo/webrender/pull/3180. I still need to do a try run and reftest before merging though.

Comment 13

[Glenn Watson [:gw]]

The try run looks good, and the patch has landed in WR, so this will be fixed by the next WR update.