mozrunner starts 'adb logcat' processes but doesn't manage them

RESOLVED FIXED in Firefox 64

Status

enhancement
P1
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: gbrown, Assigned: gbrown)

Tracking

Version 3
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment)

start_logcat() launches an adb process and returns the proc. connect() calls start_logcat and stores the return value, but doesn't do anything with it.

The wptrunner uses both of these mechanisms, performs no cleanup, and connects multiple times. As a result, after a few test groups have been completed, there are multiple logcat processes running, half of them logging to files, half of them logging to stdout. In addition, when run from mozharness, the mozharness script collects logcat for the duration of the task, and makes the log available as a test artifact.

If we are keeping logcat management in mozrunner, it should be delegated to existing support in mozdevice, rather than launching an adb process. Also, we need to make sure these logcats are not only started, but stopped.

However, I think it might be better to remove all the logcat functionality from mozrunner. There's no need for additional logcat'ing in mozharness tasks. Locally, developers usually run logcat manually.
Assignee: nobody → gbrown
The existing logcat collection code in mozrunner is problematic. Rather than fix it, I'd prefer to remove it. In CI, mozharness scripts already collect the full logcat. When running locally, testers/developers can usually achieve better results by running logcat independent of the test harness, either using 'adb logcat' from the command line, using an ide, or using a specialized logcat tool.

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=1c47793c21cee410323837a9b3036d014d108a24
Attachment #9015638 - Flags: review?(dburns)
Blocks: 1495430
Attachment #9015638 - Flags: review?(dburns) → review+
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/11f33f3c73b4
Remove logcat functionality from mozrunner; r=automatedtester
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/11f33f3c73b4
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13479 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13479
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/cO6wfbk_SNmHF5MferCXaQ)
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.