Run minidump-analyzer at a lower process priority

RESOLVED FIXED in Firefox 64

Status

()

RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: mconley, Assigned: gsvelto)

Tracking

unspecified
mozilla64
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

(Whiteboard: [qf])

Attachments

(1 attachment)

(Reporter)

Description

4 months ago
minidump-analyzer is run whenever we experience a crash - it's a separate process that attempts to gather stack traces from a crash dump.

My hypothesis is that, especially in the case of a content process crash, what a user is likely going to want to do is to get moving immediately back to the task that the crash interrupted.

I think we do them a slight disservice if the minidump-analyzer is stealing valuable CPU cycles right at the time when they're likely annoyed by a crash, and want their computer to go back to what it was doing before.

One thing we might try is to see if we can run the minidump-analyzer at a lower process priority. I suppose this has the added risk of the computer shutting down before the dump is properly analyzed (since we're effectively slowing down the process of getting the stacks).
(Reporter)

Comment 1

4 months ago
Thoughts on this, gsvelto?
Flags: needinfo?(gsvelto)
(Assignee)

Comment 2

4 months ago
It's a good idea and an easy one to implement too. It should be a (platform-dependent) one-liner in the minidump-analyzer tool to drop the priority as soon as it starts.
Flags: needinfo?(gsvelto)
(Reporter)

Updated

4 months ago
Whiteboard: [qf]
(Reporter)

Comment 3

4 months ago
Thanks!
Summary: Consider running minidump-analyzer at a lower process priority → Run minidump-analyzer at a lower process priority
(Assignee)

Updated

4 months ago
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
(Assignee)

Comment 4

4 months ago
Created attachment 9015951 [details]
Bug 1497692 - Lower the minidump-analyzer priority

Comment 5

4 months ago
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3d26ec88c8d
Lower the minidump-analyzer priority r=ted

Comment 6

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/f3d26ec88c8d
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.