Closed Bug 1497692 Opened 2 years ago Closed 2 years ago

Run minidump-analyzer at a lower process priority

Categories

(Toolkit :: Crash Reporting, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: mconley, Assigned: gsvelto)

Details

(Whiteboard: [qf])

Attachments

(1 file)

minidump-analyzer is run whenever we experience a crash - it's a separate process that attempts to gather stack traces from a crash dump.

My hypothesis is that, especially in the case of a content process crash, what a user is likely going to want to do is to get moving immediately back to the task that the crash interrupted.

I think we do them a slight disservice if the minidump-analyzer is stealing valuable CPU cycles right at the time when they're likely annoyed by a crash, and want their computer to go back to what it was doing before.

One thing we might try is to see if we can run the minidump-analyzer at a lower process priority. I suppose this has the added risk of the computer shutting down before the dump is properly analyzed (since we're effectively slowing down the process of getting the stacks).
Thoughts on this, gsvelto?
Flags: needinfo?(gsvelto)
It's a good idea and an easy one to implement too. It should be a (platform-dependent) one-liner in the minidump-analyzer tool to drop the priority as soon as it starts.
Flags: needinfo?(gsvelto)
Whiteboard: [qf]
Thanks!
Summary: Consider running minidump-analyzer at a lower process priority → Run minidump-analyzer at a lower process priority
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3d26ec88c8d
Lower the minidump-analyzer priority r=ted
https://hg.mozilla.org/mozilla-central/rev/f3d26ec88c8d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.