1497708 - moz-phab doesn't play well with git worktrees

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Bobby Holley (:bholley)]

In git, you can create multiple working directories for the same underlying repository with `git worktree add`. This is useful to work on multiple projects simultaneously without invalidating builds when context switching.

moz-phab doesn't seem to handle this. Running it in a git worktree, I get:

> bholley@slice /files/mozilla/mc/q (stop_reinitializing_textures) $ moz-phab submit
> Not a repository (or any of the parent directories): .hg / .git

Comment 1

[Piotr Zalewa [:zalun]]

After a talk on IRC. 
This happens when worktree is created outside of git workdir.
`git worktree add ../foo`

`Git.__init__` will be more complicated.
We will need to check if `.git` exists (file or dir), and find the "dot path" using `git rev-parse --git-common-dir`.

Comment 2

[Piotr Zalewa [:zalun]]

Attachment: Git worktree support

moz-phab tries to recognize if it's called from a git repository by
looking for a `.git` directory in current path. If a user created a
worktree outside of a git repository (by running `git worktree add ../some-worktree`),
moz-phab can't find the main `.git` dir.
This patch makes it recognize the workdir's `.git` file and runs
`git rev-parse --git-common-dir` to find the real `.git ` directory.