Open Bug 1497731 Opened 3 years ago Updated 4 months ago

Clearing history with a range (via "clear recent history" or forget button) removes ALL session store backups regardless of range

Categories

(Firefox :: Session Restore, defect, P3)

62 Branch
defect

Tracking

()

People

(Reporter: jscher2000, Unassigned)

References

(Blocks 1 open bug)

Details

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0

Steps to reproduce:

Click Forget button, set range to 5 minutes, trigger the operation.


Actual results:

In the Library window, History visits for the past 5 minutes are removed. However, also, the entire contents of the sessionstore-backups folder is removed regardless of file dates.


Expected results:

Only session history files updated within the past 5 minutes (at most, preferably only session history data from the past 5 minutes) would be removed.

SuMo ref with screenshots: https://support.mozilla.org/questions/1236644#answer-1162840

The SessionHistoryCleaner appears to support a time range --

const SessionHistoryCleaner = {
  deleteByRange(aFrom, aTo) {
    return new Promise(aResolve => {
      Services.obs.notifyObservers(null, "browser:purge-session-history", String(aFrom));
      aResolve();
    });
  },

  deleteAll() {
    return new Promise(aResolve => {
      Services.obs.notifyObservers(null, "browser:purge-session-history");
      aResolve();
    });
  },
};

https://dxr.mozilla.org/mozilla-central/source/toolkit/components/cleardata/ClearDataService.js#477

-- but maybe this is an illusion and the range is not actually implemented.
Yeah, it looks like https://searchfox.org/mozilla-central/rev/65f9687eb192f8317b4e02b0b791932eff6237cc/browser/components/sessionstore/SessionStore.jsm#1761 just removes all the files - the range argument doesn't get passed in.
Status: UNCONFIRMED → NEW
Component: Untriaged → Session Restore
Ever confirmed: true
Summary: Forget button sanitizer removes ALL session history regardless of range → Clearing history with a range (via "clear recent history" or forget button) removes ALL session store backups regardless of range
I don't think this was ever implemented? I don't recall SessionFile to ever have had a notice of a 'range' to wipe. Marking as a feature request.
Blocks: ss-feature
Priority: -- → P3
See Also: → 1607383
You need to log in before you can comment on or make changes to this bug.