Closed
Bug 1497734
Opened 7 years ago
Closed 7 years ago
Rename nsStaticAtom subclasses
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
References
Details
Attachments
(1 file)
|
22.69 KB,
patch
|
heycam
:
review+
|
Details | Diff | Splinter Review |
The current names are a bit daft.
|
Assignee | |
Comment 1•7 years ago
|
||
Specifically:
- nsICSSAnonBoxPseudo --> nsCSSAnonBoxPseudoStaticAtom
- nsICSSPseudoElement --> nsCSSPseudoElementStaticAtom
The `nsI` prefix isn't necessary because these are no longer XPIDL types, and
the `StaticAtom` suffix makes their meaning clearer.
Attachment #9015748 -
Flags: review?(cam)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 9015748 [details] [diff] [review]
Rename nsStaticAtom subclasses
Review of attachment 9015748 [details] [diff] [review]:
-----------------------------------------------------------------
::: layout/style/nsCSSPseudoElements.h
@@ +102,5 @@
> #ifdef DEBUG
> static void AssertAtoms();
> #endif
>
> // Alias nsCSSPseudoElements::foo() to alias nsGkAtoms::foo.
Oops, I wrote "alias" twice. Mind fixing this while you're here?
Attachment #9015748 -
Flags: review?(cam) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
> Oops, I wrote "alias" twice. Mind fixing this while you're here?
Sure. And I'll fix the same problem on the equivalent nsCSSAnonBoxes code.
Pushed by nnethercote@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3924e39ce03a
Rename nsStaticAtom subclasses. r=heycam
|
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•