Closed Bug 1497734 Opened Last year Closed Last year

Rename nsStaticAtom subclasses

Categories

(Core :: CSS Parsing and Computation, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: njn, Assigned: njn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The current names are a bit daft.
Specifically:
- nsICSSAnonBoxPseudo --> nsCSSAnonBoxPseudoStaticAtom
- nsICSSPseudoElement --> nsCSSPseudoElementStaticAtom

The `nsI` prefix isn't necessary because these are no longer XPIDL types, and
the `StaticAtom` suffix makes their meaning clearer.
Attachment #9015748 - Flags: review?(cam)
Blocks: 1257126
Comment on attachment 9015748 [details] [diff] [review]
Rename nsStaticAtom subclasses

Review of attachment 9015748 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/style/nsCSSPseudoElements.h
@@ +102,5 @@
>  #ifdef DEBUG
>    static void AssertAtoms();
>  #endif
>  
>    // Alias nsCSSPseudoElements::foo() to alias nsGkAtoms::foo.

Oops, I wrote "alias" twice.  Mind fixing this while you're here?
Attachment #9015748 - Flags: review?(cam) → review+
> Oops, I wrote "alias" twice.  Mind fixing this while you're here?

Sure. And I'll fix the same problem on the equivalent nsCSSAnonBoxes code.
https://hg.mozilla.org/mozilla-central/rev/3924e39ce03a
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.