Closed Bug 1497842 Opened Last year Closed 9 months ago

Remove INSTALL_LOCALE from APP_CONSTANTS

Categories

(Toolkit :: General, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: Pike, Assigned: manuela.monika97, Mentored)

Details

Attachments

(1 file)

Right now, we have 

  INSTALL_LOCALE: "@AB_CD@",

in https://searchfox.org/mozilla-central/rev/80ac71c1c54af788b32e851192dfd2de2ec18e18/toolkit/modules/AppConstants.jsm#309.

That's wrong for repacks.

It's hardly used per https://searchfox.org/mozilla-central/search?q=INSTALL_LOCALE&case=false&regexp=false&path=, and I guess it's better to just remove it, instead of trying to fix it.

https://searchfox.org/mozilla-central/rev/fbb251448feb7276f9b1d0a88f9c0cb1cd144ce4/toolkit/modules/UpdateUtils.jsm#125 is where the locale is coming from. And we're using that file because it's the only thing that's really reliable to tell us what we built :-/ .

One way to fix this is to assume that we're running tests on en-US only, add a big red marker on it, and hard-code en-US?

Or you read the file, and check that you read the file correctly twice.

(Thanks for looking into this)

Flags: needinfo?(l10n)

Hi, I'd like to work on this

Hi Monika, sorry, I only just saw your comment. Please do take it. With reference to comment 2, I think we could just hard-code en-US in the test for now, and extend the Assert message to indicate that the test is assuming that we are built with en-US locale.

Assignee: nobody → manuela.monika97
Mentor: standard8
Status: NEW → ASSIGNED
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9f7a419466c3
Remove INSTALL_LOCALE from APP_CONSTANTS r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.