1497884 - Visual glitches when changing device orientation

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P2)

Description

[Sorina Florean [:sflorean]]

Environment: 
Device: Motorola Nexus 6(Android 7.1.1), Xiaomi Mi4i(Android 5.0.2);
Build: Nightly 64.0a1 (2018-10-10), 63.0b11;

Steps to reproduce:
1. Launch Fennec and go to espn.com, cnn.com. newyorker.com;
2. Change device orientation from portrait to landscape a couple of times;
3. Optional: Don't interact with the message "about cookies". 

Expected result:
No visual issues when orientation is changed.

Actual result:
Visual issues are displayed when device orientation is changed (header from the site is flickering).

Video: https://drive.google.com/open?id=1Q7m3m_rF4O6xZyTi9lIFcrVOjsGq6FGr

Pushlog:https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c6e7b65bf8b02a32a6c1d583eb1d79e3116d692d&tochange=bac4139e4ff9b3071e1ce17113ac65ed1d8e8598

Comment 1

[Botond Ballo [:botond]]

I can't reproduce this myself, but based on the video and regression range, I can see it being a regression from bug 1465616.

This would have been fixed by the original patch in bug 1495055 (which got backed out). Unfortunately, it's not going to be fixed by the new patch in bug 1495055, which is limited in scope to dynamic toolbar transitions.

We may have to accept this regression in 63 while we work on getting the original fix from bug 1495055 into a landable state. Note that the visual glitch in question is temporary (the rendering corrects itself a split second later), and only occurs when changing device orientation, so this seems acceptable.

Comment 2

[Botond Ballo [:botond]]

(In reply to Botond Ballo [:botond] from comment #1)
> This would have been fixed by the original patch in bug 1495055 (which got
> backed out). Unfortunately, it's not going to be fixed by the new patch in
> bug 1495055, which is limited in scope to dynamic toolbar transitions.
> 
> We may have to accept this regression in 63 while we work on getting the
> original fix from bug 1495055 into a landable state. Note that the visual
> glitch in question is temporary (the rendering corrects itself a split
> second later), and only occurs when changing device orientation, so this
> seems acceptable.

Update: the patch in bug 1495055 has been updated again, and the new patch should fix this problem after all.

Comment 3

[Botond Ballo [:botond]]

Sorina, the latest Fennec nightly contains the fix for bug 1495055. Could you check if it fixes the problem (as I couldn't reproduce it in the first place)?

Comment 4

[Sorina Florean [:sflorean]]

(In reply to Botond Ballo [:botond] from comment #3)
> Sorina, the latest Fennec nightly contains the fix for bug 1495055. Could
> you check if it fixes the problem (as I couldn't reproduce it in the first
> place)?

Tested on the Nightly build from 2018/10/15 and I can confirm the fix on affected devices. Followed the steps from the description and also recommended Pocket stories and no glitches were present when changing device orientation. 
I will check on 63 when bug 1495055 lands on Beta. Thanks!

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Closing as fixed by bug 1495055.