1497910 - Firefox flickers white while starting

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Jeff Muizelaar [:jrmuizel]]

During startup the Firefox window will be white then it draws something then goes all white before finally drawing again. I've been seeing this for a while.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Sotaro or Matt have you seen this?

Comment 2

[Sotaro Ikeda [:sotaro]]

I saw it this week, but I could not reproduce it with latest nightly today.

Comment 3

[Jeff Muizelaar [:jrmuizel]]

I think this might only happen on the first load after updating. Perhaps shader cache related?

Comment 4

[Sotaro Ikeda [:sotaro]]

Yea, I confirmed it during first load after updating. But it is not clear if shader cache is related. Just reset shader disk cache and restart Firefox did not cause the problem.

Comment 5

[Sotaro Ikeda [:sotaro]]

Ah, it seems like to related to gfx/SanityTest.js. I confirmed the problem on P50(Win10) with the following STR.

[STR]
[1] Enable WebRender by setting pref gfx.webrender.all;true.
[2] Reset pref sanity-test.advanced-layers.
[3] Restart firefox

Comment 6

[Sotaro Ikeda [:sotaro]]

(In reply to Sotaro Ikeda [:sotaro] from comment #5)
> Ah, it seems like to related to gfx/SanityTest.js. I confirmed the problem
> on P50(Win10) with the following STR.
> 
> [STR]
> [1] Enable WebRender by setting pref gfx.webrender.all;true.
> [2] Reset pref sanity-test.advanced-layers.
> [3] Restart firefox

We also enable WebRender profiler ui. Somehow Bug 1436020 does not work anymore now.

Comment 7

[Sotaro Ikeda [:sotaro]]

WebRenderBridgeParent::RecvGetSnapshot() seemed to readback obsoleted data. RendererOGL::UpdateAndRender() disables debug flags during readback, but readback data had wr profile ui.

Comment 8

[Sotaro Ikeda [:sotaro]]

It seems that wr_renderer_readback() needs to be called before calling RenderCompositorANGLE::EndFrame() during readback.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Call wr_renderer_readback() before calling RenderCompositor::EndFrame()

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Call wr_renderer_readback() before calling RenderCompositor::EndFrame()

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Call wr_renderer_readback() before calling RenderCompositor::EndFrame()

Comment 12

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Call wr_renderer_readback() before calling RenderCompositor::EndFrame()

Comment 13

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6615c1b59b39d2e9b54d3bceb21ad668073eaeb

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Call wr_renderer_readback() before calling RenderCompositor::EndFrame()

Comment 15

[Sotaro Ikeda [:sotaro]]

With attachment 9017379 [details] [diff] [review] and enabled dump of gfxUtils::WriteAsPNG(snapshot, filename)  in WebRenderLayerManager::MakeSnapshotIfRequired(), I did not saw profiler ui in the snapshot.

 https://dxr.mozilla.org/mozilla-central/source/gfx/layers/wr/WebRenderLayerManager.cpp#436

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52a35a1526e7
Call wr_renderer_readback() before calling RenderCompositor::EndFrame() r=nical

Comment 17

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/52a35a1526e7