1497980 - Backout bug 1481473 (hide the 'duplicate tab' item when multiple tabs are selected)

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, enhancement, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

This is the only menuitem we're hiding when multiple tabs are selected, and there is no functional reason why. Note too that Google Chrome does have a "Duplicate tabs" menuitem for their multiselection so it makes sense for cross-browser consistency to offer the same feature parity here.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1497980 - Add a 'Duplicate Tabs' menuitem when multiple tabs are selected. r?Felipe

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1497980 - Add a 'Duplicate Tabs' menuitem when multiple tabs are selected. r?Felipe,dao

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4ff11c25342d
Add a 'Duplicate Tabs' menuitem when multiple tabs are selected. r=Felipe

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing bc at browser/base/content/test/tabs/browser_multiselect_tabs_duplicate.js

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=210870143&revision=4ff11c25342dc8d18d406a2a82af27896c1d9714

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=210886552&repo=autoland&lineNumber=1689

Backout: https://hg.mozilla.org/integration/autoland/rev/8649e6a6c122e7d21c9240090ef3a69b435c16c7

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/07394876f5be
Add a 'Duplicate Tabs' menuitem when multiple tabs are selected. r=Felipe,dao

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/07394876f5be

Comment 7

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Verified fixed that this implementation is present on the latest Nightly 65.0a1(2018-11-22).