1498022 - [dev] Running moz-phab twice on the same stack freezes the program

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Māris Fogels [:mars] (please needinfo)]

When running a development version of moz-phab inside the development container the program freezes waiting for text editor input if you run it twice on the same stack of commits.

The frozen program does not respond to Ctrl-C (SIGINT).  The only way to kill the program is to hit Ctrl-Z (SIGTSTP) and "kill %1" the process.

I tested with: 

mozilla-conduit/suite cf7ccb3c45d73031267c87aa9a7a2991a719a741
mozilla-conduit/review 3b8bf113f43b0dd3d2fe9b4341d490bad57211e9

STR:

1. Checkout master branch mozilla-conduit/suite
2. Checkout master branch of mozilla-conduit/review
3. Run suite as usual: $ docker-compose up
4. Run the local-dev container: $ docker-compose -f docker-compose.yml -f docker-compose.review.yml run local-dev
5. Build a nice, linear stack of hg commits: $ ./clone_repositories.sh; etc. etc.
6. Run moz-phab for the initial submission: $ moz-phab submit -b 1
7. Everything should complete as usual
8. Check out tip: hg checkout tip
9. Run moz-phab a second time: $ moz-phab submit -b 1

What should happen:

moz-phab should complete successfully? (I couldn't get it to work.)

What actually happens:

Vim complains that "Output is not to a terminal" and the program freezes.



--- begin terminal output ---

phab@dbc383266767:~/test-repo$ moz-phab submit --trace -b 1
Your version of Python does not validate HTTPS certificates.  Please consider upgrading to Python 2.7.9 or later.
Submitting 3 commits:
3:4d6058cf8d40 Bug 1 - C
!! Missing reviewers
2:ba558b9d1ea7 Bug 1 - B
!! Missing reviewers
1:10f1ec8c8cdd Bug 1 - A
!! Missing reviewers
Submit to http://phabricator.test (YES/No/Always)? YES

Creating new revision:
1:10f1ec8c8cdd Bug 1 - A
Config: Reading user configuration file "/home/phab/.arcrc"...
Config: Did not find system configuration at "/etc/arcconfig".
Working Copy: Reading .arcconfig from "/home/phab/test-repo/.arcconfig".
Working Copy: Path "/home/phab/test-repo" is part of `hg` working copy "/home/phab/test-repo".
Working Copy: Project root is at "/home/phab/test-repo".
Config: Did not find local configuration at "/home/phab/test-repo/.hg/arc/config".
>>> [0] (+0) <http> http://phabricator.test/api/user.whoami
<<< [0] (+111) <http> 111,849 us
>>> [1] (+117) <exec> $ HGPLAIN=1 hg status
<<< [1] (+223) <exec> 105,818 us
>>> [2] (+224) <event> diff.didCollectChanges <listeners = 0>
<<< [2] (+224) <event> 93 us
>>> [3] (+225) <http> http://phabricator.test/api/differential.parsecommitmessage
<<< [3] (+375) <http> 150,418 us
>>> [4] (+376) <conduit> differential.query() <bytes = 139>
>>> [5] (+376) <http> http://phabricator.test/api/differential.query
<<< [5] (+505) <http> 128,983 us
<<< [4] (+505) <conduit> 129,352 us
>>> [6] (+506) <event> diff.didBuildMessage <listeners = 0>
<<< [6] (+506) <event> 104 us
>>> [7] (+506) <http> http://phabricator.test/api/differential.getcommitmessage
<<< [7] (+637) <http> 131,273 us
>>> [8] (+638) <http> http://phabricator.test/api/differential.parsecommitmessage
<<< [8] (+776) <http> 138,137 us
>>> [9] (+778) <exec> $ HGPLAIN=1 hg log -l 1 --template '{node}' -r '.^' --
<<< [9] (+891) <exec> 112,883 us
>>> [10] (+892) <exec> $ HGPLAIN=1 hg branch
<<< [10] (+1,012) <exec> 119,808 us
>>> [11] (+1,012) <exec> $ HGPLAIN=1 hg log --template '{node}<...binary data...>' --rev '('\''6391f9517e417ada8a7f27d142cf297cbb1ae751'\''::. - '\''6391f9517e417ada8a7f27d142cf297cbb1ae751'\'')' --branch 'default' --
<<< [11] (+1,121) <exec> 108,756 us
>>> [12] (+1,123) <exec> $ vi '/tmp/edit.eant6mftt4owwoog/differential-update-comments'
Vim: Warning: Output is not to a terminal


--- end terminal output ---

Comment 1

[:glob ✱]

can you re-run with DEBUG=1 (we should probably make DEBUG=1 and --trace the same).

Comment 2

[Māris Fogels [:mars] (please needinfo)]

Attachment: fozen-terminal-with-debug-log.txt

Comment 3

[Piotr Zalewa [:zalun]]

We had a test session with :mars.

This is because Suite is working on http and `ARC_DIFF_REV_RE` expects it to be https.
The url is not found in the commit message and moz-phab thinks the revision has to be created.
I'll submit a revision with a quick fix to avoid that in Suite environment.

I don't know why moz-phab calls the editor. It is a bug in moz-phab when one wants to recreate a commit which was already submitted.

Comment 4

[Piotr Zalewa [:zalun]]

It might be the error never happens in a real-world situation.

Comment 5

[Māris Fogels [:mars] (please needinfo)]

The patch in bug 1498292 fixed this for me.