Closed
Bug 1498047
Opened 6 years ago
Closed 6 years ago
Fix ARM64 generateInvalidator() trampoline
Categories
(Core :: JavaScript Engine: JIT, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla65
Tracking | Status | |
---|---|---|
firefox65 | --- | fixed |
People
(Reporter: sstangl, Assigned: sstangl)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
5.31 KB,
patch
|
nbp
:
review+
|
Details | Diff | Splinter Review |
ARM64's generateInvalidator() was incorrect: the wrong registers were pushed, and the return address was missing from the stack.
Attachment #9016099 -
Flags: review?(jitbugs)
Updated•6 years ago
|
Priority: -- → P2
Updated•6 years ago
|
Attachment #9016099 -
Flags: review?(jitbugs) → review?(nicolas.b.pierron)
Updated•6 years ago
|
Attachment #9016099 -
Flags: review?(nicolas.b.pierron) → review+
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/f4d8966d0af4
Fix generateInvalidator(). r=nbp
Keywords: checkin-needed
Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e28ac6527a9
Fix generateInvalidator(). a=nbp
Comment 3•6 years ago
|
||
Backout link: https://hg.mozilla.org/integration/mozilla-inbound/rev/540bd4c32be5
Backed out 2 changesets (bug 1498371, bug 1498047) pushed on the wrong tree.
Comment 4•6 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in
before you can comment on or make changes to this bug.
Description
•