1498092 - Fix forced frame rendering

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P2)

Description

[Sotaro Ikeda [:sotaro]]

Bug 1461239 added capability to skip WR frame rendering if there is no update. But it forgot to add necessary "force frame rendering".

Comment 1

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add necessary force frame rendering

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add necessary force frame rendering

Comment 3

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add necessary force frame rendering

Comment 4

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add necessary forced frame rendering

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add necessary forced frame rendering

Comment 6

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add necessary forced frame rendering

Comment 7

[Nicolas Silva [:nical]]

Comment on attachment 9016228 [details] [diff] [review]
patch - Add necessary forced frame rendering

Review of attachment 9016228 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/CompositorBridgeParent.cpp
@@ +941,5 @@
>      return;
>    }
>  
>    if (mWrBridge) {
> +    mWrBridge->ScheduleForcedGenerateFrame();

Could you explain why we need to force generating the frame in this case?

Comment 8

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9016228 [details] [diff] [review]
patch - Add necessary forced frame rendering

Review of attachment 9016228 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ipc/CompositorBridgeParent.cpp
@@ +941,5 @@
>      return;
>    }
>  
>    if (mWrBridge) {
> +    mWrBridge->ScheduleForcedGenerateFrame();

Oh, sorry, it is a mistake.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add necessary forced frame rendering

Comment 10

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9016481 [details] [diff] [review]
patch - Add necessary forced frame rendering

:nical, can you review the patch again?

Comment 11

[Nicolas Silva [:nical]]

Comment on attachment 9016481 [details] [diff] [review]
patch - Add necessary forced frame rendering

Review of attachment 9016481 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderBridgeParent.cpp
@@ +1389,5 @@
>  
>  mozilla::ipc::IPCResult
>  WebRenderBridgeParent::RecvScheduleComposite()
>  {
> +  ScheduleForcedGenerateFrame();

As far as I can tell we receive this message for APZ related things for which the render backend should be able to figure out on its own whether the frame has changed without the need to invalidate the rendered frame manually. Could you explain why we need this here as well?

Comment 12

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9016481 [details] [diff] [review]
patch - Add necessary forced frame rendering

Review of attachment 9016481 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderBridgeParent.cpp
@@ +1389,5 @@
>  
>  mozilla::ipc::IPCResult
>  WebRenderBridgeParent::RecvScheduleComposite()
>  {
> +  ScheduleForcedGenerateFrame();

I agree. It is better to change to ScheduleGenerateFrame().

Comment 13

[Sotaro Ikeda [:sotaro]]

Comment on attachment 9016481 [details] [diff] [review]
patch - Add necessary forced frame rendering

Review of attachment 9016481 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/wr/WebRenderBridgeParent.cpp
@@ +1389,5 @@
>  
>  mozilla::ipc::IPCResult
>  WebRenderBridgeParent::RecvScheduleComposite()
>  {
> +  ScheduleForcedGenerateFrame();

In Bug 1461239, I misunderstood this function is use for RecvForcePresent().

Comment 14

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Add necessary forced frame rendering

Addressed the comment.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ad88a9f8f35
Add necessary forced frame rendering r=nical

Comment 16

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3ad88a9f8f35