1498183 - Replace generator/yield in test_constraint_error_messages.js to async/await

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect, P2)

Description

[Diego Pino]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3497.100 Safari/537.36

Steps to reproduce:

Follow-up bug of https://bugzilla.mozilla.org/show_bug.cgi?id=1357561. See comments: https://bugzilla.mozilla.org/show_bug.cgi?id=1357561#c21 and https://bugzilla.mozilla.org/show_bug.cgi?id=1357561#c30

Comment 1

[Marion Daly [:mdaly]]

Tom, can you take a look?

Comment 2

[Tom Tung [:tt, :ttung]]

Work in progress, and should provide a patch after a day or two.

Comment 3

[Tom Tung [:tt, :ttung]]

Attachment: Bug 1498183 - Supporting async/await for mochitest and xpcshell test in indexedDB;

This patch mainly uses add_task while running async/await scripts. To support that in workers, it also changes testHarness logic for worker from "yield" to promise.

Comment 4

[Tom Tung [:tt, :ttung]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0432c2843e78aaac569e8e2233390196f3603325

I test all idb tests locally, but I should also see if they work on try

Comment 5

[Tom Tung [:tt, :ttung]]

Andrew, although you've granted the review, could you take one more look before I landing this patch? Thanks!
I think the way I use for notifying the main thread from the worker thread that the test has finished should work, but it'd be better to check by others. I didn't rebase the patch so that you could check the inter-diff directly.

I removed the call for finishTest() and adding assertion on every finishTest() functions to prevent from misusing. Also, I placed expectingSuccess() and expectingUpgrade() to both helper.js and xpcshell-head-parent.js

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Looks good! Thanks for the proactive improvements!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a74ab74ff7a
Supporting async/await for mochitest and xpcshell test in indexedDB; r=asuth

Comment 8

[Tom Tung [:tt, :ttung]]

(In reply to Andrew Sutherland [:asuth] from comment #6)

Thanks for the review!

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/4a74ab74ff7a