1498190 - Implement the 'memory' column in the new about:performance

Status: VERIFIED FIXED

(Toolkit :: Performance Monitoring, enhancement)

Description

[Florian Quèze [:florian]]

This is for the front-end piece, but this may turn out to be done in bug 1497124, in which case we can just close this bug.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Comment 2

[Florian Quèze [:florian]]

Attachment: Patch v1.1

Bug 1497124 has landed, so we can now review and land the front-end to start dogfooding the memory reporting :-).

Comment 3

[Florian Quèze [:florian]]

Comment on attachment 9026703 [details] [diff] [review]
Patch v1.1

Looks like I need an l10n review too.

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 9026703 [details] [diff] [review]
Patch v1.1

Review of attachment 9026703 [details] [diff] [review]:
-----------------------------------------------------------------

I would advise to change the kB to KB, but otherwise it looks good to me.

There is indeed still a mandatory review on FTL changes
https://firefox-source-docs.mozilla.org/intl/l10n/l10n/fluent_tutorial.html#getting-a-review

Is there are a reason not to use Phabricator? This patch would have pinged me automatically.

::: toolkit/locales/en-US/toolkit/about/aboutPerformance.ftl
@@ +38,5 @@
> +## Values for the Memory column
> +##
> +## Variables:
> +##   $value (Number) - How much memory is used
> +size-kB = { $value } kB

FYI, while this is correct to me, this is also not how en-US writes kilobytes across the product.

https://transvision.mozfr.org/?recherche=kb&repo=gecko_strings&sourcelocale=en-US&locale=en-US&search_type=strings_entities&entire_string=entire_string

You should change it to "KB" for consistency. There are a few bugs on file about that, but no action has ever been taken.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/287134f9e804
implement the 'Memory' column in about:performance, r=felipe,flod.

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/287134f9e804

Comment 7

[Gyula Palko[:gpalko]]

Verified, that the 'Memory' column is displayed in Task Manager, on Nightly 65(20181129095546).