1498211 - Update to HTML spec changes for parsing the noopener/noreferrer features

Status: NEW

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[Simon Pieters [:zcorpan]]

Per this test case it seems noopener is not supported in window.open() in Firefox. (Did it work before?)

http://web-platform-tests.live/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener.html

(Need to allow popups.)

When implementing this, noopener=0 and noopener=error should not set noopener.

See
https://github.com/whatwg/html/pull/4079
https://github.com/web-platform-tests/wpt/pull/13458

Comment 1

[Andrew McCreight [:mccr8]]

Nika, is it expected that this test will fail?

Comment 2

[Nika Layzell [:nika] (ni? for response)]

I think this is due to changes in how `noopener` is tokenized. IIRC it used to be tokenized in a special way, but now uses the more common generic mechanism.

CC :bz who implemented the initial `noopener`.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

ni? :bz who implemented noopener :-)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Bareword "noopener" works, yes?  I just tested, and it does. That's the only thing that was expected to work when I implemented it.

I haven't dug into the test and why it's failing to detect that; presumably it's not testing the simple case, except as part of tests that test other cases too or something.  And certainly our parsing is not going to be aligned yet with a spec change that happened only 2 days ago...

Comment 5

[(no longer active)]

The reason behind the test failures is that we're not using the algorithm in WinHasOption() which is more or less what the spec requires here now (the generic tokenization, that is...) But WinHasOption() as is isn't suitable to use here since we also need to remove what it parses here from the options string.

Comment 6

[(no longer active)]

BTW we should make the same change to "noreferrer" being implemented in bug 1527287 as well.

Comment 7

[Anne (:annevk)]

Also tested by html/browsers/the-window-object/window-open-noopener.html.