1498221 - The testcase for bug 1497239 still looks pretty bad.

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Emilio Cobos Álvarez (:emilio)]

Bug 1497239 fixed the scale not getting applied to filters properly, but there are still artifacts with the animation in that test-case.

Comment 1

[Markus Stange [:mstange]]

I think the profile sharing arrow panel on perf-html.io also hits this bug.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

FWIW this also glitches out on non-WR when being interacted with, but way less heavily...

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: non-WR screencast (basic composition, on Linux)

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: WR screencast.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Testcase with a CSS blur instead of a fallback SVG blur.

With a normal CSS blur WR looks fine though (non-WR has the same glitch as my first screencast), so maybe not quite the same as the other bug... 

Anyway I'll reduce the other one as well to see what's up with that.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

This was broken in Gecko by bug 1224207. I suspect the underlying bug is the same for both Gecko and WR, just it's more manifest in WR.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: without a transition

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Don't apply layer scaling to fallback filters.

Using layer scaling confuses the filter code (see bug 1497239).

Right now we're sort-of double-scaling. Looks like what the filter code expects
is just getting the scaling passed down, see bug 1224207.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

I'd appreciate sanity-checking since I'm not sure how both scales interact, but I think this is the right thing to do.

Comment 10

[Jeff Muizelaar [:jrmuizel]]

I'll take a look

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3ef66c8d682c
Don't apply layer scaling to fallback filters. r=mattwoodrow

Comment 12

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13672 for changes under testing/web-platform/tests

Comment 13

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 14

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/3ef66c8d682c

Comment 15

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged