Closed Bug 1498221 Opened 11 months ago Closed 10 months ago

The testcase for bug 1497239 still looks pretty bad.

Categories

(Core :: Graphics: WebRender, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

()

Details

Attachments

(5 files)

Bug 1497239 fixed the scale not getting applied to filters properly, but there are still artifacts with the animation in that test-case.
Flags: needinfo?(emilio)
I think the profile sharing arrow panel on perf-html.io also hits this bug.
Assignee: nobody → emilio
FWIW this also glitches out on non-WR when being interacted with, but way less heavily...
Flags: needinfo?(emilio)
Attached video WR screencast.
Flags: needinfo?(emilio)
With a normal CSS blur WR looks fine though (non-WR has the same glitch as my first screencast), so maybe not quite the same as the other bug... 

Anyway I'll reduce the other one as well to see what's up with that.
This was broken in Gecko by bug 1224207. I suspect the underlying bug is the same for both Gecko and WR, just it's more manifest in WR.
Blocks: 1224207
Attached file without a transition
Flags: needinfo?(emilio)
Using layer scaling confuses the filter code (see bug 1497239).

Right now we're sort-of double-scaling. Looks like what the filter code expects
is just getting the scaling passed down, see bug 1224207.
I'd appreciate sanity-checking since I'm not sure how both scales interact, but I think this is the right thing to do.
I'll take a look
Flags: needinfo?(jmuizelaar)
Priority: -- → P2
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/3ef66c8d682c
Don't apply layer scaling to fallback filters. r=mattwoodrow
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13672 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
https://hg.mozilla.org/mozilla-central/rev/3ef66c8d682c
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Upstream PR merged
Flags: needinfo?(jmuizelaar)
You need to log in before you can comment on or make changes to this bug.