1498236 - The "Save" button is wrongly displayed instead of the "Done" one if a "Highlights" or a "Recommended by Pocket" card is bookmarked

Status: RESOLVED DUPLICATE of bug 1473861

(Firefox :: New Tab Page, defect, P3)

Description

[Marius Coman [:mcoman], Ecosystem QA]

Attachment: rec of the issue.gif

[Affected versions]:
- Firefox 63.0b13 Build ID - 20181008155858
- Firefox 64.0a1 Build ID - 20181010235834

[Affected Platforms]:
- All Windows
- All Linux
- All Mac

[Prerequisites]:
- Have a new Firefox profile.
- Have the "browser.search.region" pref set to "US" in the "about:config" page:

[Steps to reproduce]:
1. Open the browser with the profile from prerequisites.
2. Open a new tab and hover any "Pocket" recommendation.
3. Click the menu button from the top right part of the recommendation.
4. Select the "Bookmark" option and observe the behavior.

[Expected result]:
- The "New Bookmark" dialog box is opened and the "Done" and "Cancel" buttons are displayed in the bottom part of it.

[Actual result]:
- The "Save" and "Cancel" buttons are displayed instead.

[Notes]:
- It seems that this behavior is caused by Bug 1472472.
- This issue is reproducible if you will bookmark a "Highlights" card instead.
- Attached a screen recording of the issue.

Comment 1

[Dão Gottwald [:dao]]

This dialog is a bit different from the doorhanger, but unless I'm missing something there's nothing inherently wrong with the button being labeled "Save". The long-term plan is bug 1473861.