Closed Bug 1498238 Opened Last year Closed 10 months ago

Add icons to control center for allowed and blocked images

Categories

(Firefox :: Site Identity, enhancement, P3)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 66
Tracking Status
firefox66 --- fixed
firefox67 --- verified
firefox68 --- verified
firefox69 --- verified

People

(Reporter: rfeeley, Assigned: jallmann)

Details

Attachments

(2 files)

Attached file image-svg.zip
Some of the permissions, when set through Page Info, are missing icons in the Control Center.

One such icon is Load Images. Blocked and Allowed versions are attached.

I suspect we are using anti-footgun measures to revert this setting to the default. I have only been able to get Blocked version to appear in the Control Center. Removing the default and selecting Allow does not appear in the Control Center at all.

So perhaps only the Blocked version attached is required.
Component: General → Site Identity and Permission Panels
Priority: -- → P3
Assignee: nobody → jallmann
Status: NEW → ASSIGNED
Keywords: checkin-needed

Pushed by dvarga@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/21dc0a08a951
Insert permission icons for Load Images, r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66

Hi. Can you provide us with a way to verify this bug? Thanks.

Flags: needinfo?(jallmann)

Sure, here are steps to verify this bug:

Case 1:
Open any webpage.
Open context menu and select "View page info".
Select tab "Permissions", scroll to "Load images", deselect "Use Default" and toggle option "Block".
Close "Page info" window and open page identity popup in the url-bar.
Verify the permission "Load images" is displayed under "Permissions" as "blocked" with the correct icon.

Case 2:
Set pref "permissions.default.image" to 0.
Repeat the steps above, just exchange "Allow" for "Block".
Verirfy that "Load images" is displayed in the page identity popup as "Allowed" with the correct icon.

In both cases, only the non-default setting should appear in the page identity popup.

Is that enough information to work with?

Flags: needinfo?(jallmann)

Yes, the information was just enough. I have verified this implementation on Nightly v69.0a1, Beta v68.0b6 and Release v67.0 on Windows 10, Mac OS 10.14.5 and Ubuntu 18.04. Thank you.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.