1498242 - Separate input and output notifications when register for collection changes

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P2)

Description

[Alex Chronopoulos [:achronop]]

We need to enhance `cubeb_register_device_collection_changed()` to allow registering different callbacks for input and output. Currently we can register one callback either for input or output or both.

Before cubeb remote we could workaround this issue by using two independent cubeb instances, one for input and one for output. With cubeb remote this is not easy and we need to re-use the existing one cubeb instance.

Comment 1

[Alex Chronopoulos [:achronop]]

PR for pulse backend:
https://github.com/kinetiknz/cubeb/pull/464

Comment 2

[Alex Chronopoulos [:achronop]]

PR for audiounit backend:
https://github.com/kinetiknz/cubeb/pull/465

Comment 3

[Alex Chronopoulos [:achronop]]

PR for rust pulse backend:
https://github.com/djg/cubeb-pulse-rs/pull/39

Comment 4

[C.M.Chang[:chunmin]]

I was wondering if we have use case for it now. It seems that MediaEngineWebRTC registers the callbacks for input scope only[0].

[0] https://searchfox.org/mozilla-central/rev/eef79962ba73f7759fd74da658f6e5ceae0fc730/dom/media/webrtc/MediaEngineWebRTC.cpp#367,381

Comment 5

[Alex Chronopoulos [:achronop]]

I am implementing the output enumeration in Bug 1482150 and I am blocked because of that.

Comment 6

[Alex Chronopoulos [:achronop]]

Fixed by 1500377.