1498249 - XCUITests: Cannot get from BrowserTab to TabTray intermittent error

Status: RESOLVED FIXED

(Firefox for iOS :: Build & Test, enhancement)

Description

[Isabel Rios[:isabel_rios]]

Due to the latest changes on xcode and iOS version. This error has started to appear frequently when running the tests.

The tests fail when trying to go to TabTray from BrowserTab, although the button is shown it is not available when the tests try to tap on it and so they fail.

Since it is not possible to add a wait for that button in the ScreenGraph to wait to go to the TabTray once the button for that is available it would be needed to add that wait in the tests that are failing if possible.

Examples of tests that have failed due to that so far:
-testTabCountShowsOnlyNormalOrPrivateTabCount
-testClosePrivateTabsOptionClosesPrivateTabs
-testClosePrivateTabsOptionClosesPrivateTabsShortCutiPad
-testSearchFieldClearedAfterVisingWebsite
-testSearchTabs
-testLandscapeNavigationWithTabSwitch
-testPrivateClosedSiteDoesNotAppearOnRecentlyClos

But this error could appear in any test that needs to go to TabTray.

Comment 1

[Isabel Rios[:isabel_rios]]

Similarly, there is an error that cannot get from BrowserTab to PageOptionsMenu affecting the bookmarks tests:
-testBookmarkingUI
-testAccessBookmarksFromContextMenu

In this case it is needed to wait for the page options menu button to be available before trying to open that menu.

Comment 2

[Isabel Rios[:isabel_rios]]

-testTypingBadURL (failing on L#54 when trying to go to BrowserTabMenu from BrowserTab)

The issue is similar, in the end the problem is that being in BrowserTab looks like the options there are not available although the buttons are there and ready to be used.

Comment 3

[Isabel Rios[:isabel_rios]]

Attachment: GitHub Pull Request

Comment 4

[Isabel Rios[:isabel_rios]]

Comment on attachment 9017605 [details] [review]
GitHub Pull Request

I hope that at least most of the routing issues from BrowserTab to TabTray are fixed now. If those issues are still seen I don't see other option but to go following each step in the test instead of using the graph...or if there is a better option I could try...

Comment 5

[Isabel Rios[:isabel_rios]]

Holding to land this PR since it adds many changes and tests started to pass again except for two or three that can be managed differently...

Comment 6

[Isabel Rios[:isabel_rios]]

Landed on master:
https://github.com/mozilla-mobile/firefox-ios/commit/920c18953810d7b79082a544f0f3a9b379912b2e

Let's wait to uplift to v14.x until the issues do not appear on master