1498287 - browser.xhtml ignores RTL via intl.uidirection: devtools/client/inspector/animation/test/browser_animation_current-time-scrubber-rtl.js is permaorange

Status: RESOLVED FIXED

(DevTools :: Inspector: Animations, defect, P2)

Description

[Brian Grinstead [:bgrins]]

This is the last failing devtools test with `export MOZ_BROWSER_XHTML=1`

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cffd593ca7ebbd76acfc37f2213725a23bd76c6e&selectedJob=204616528

Comment 1

[Brian Grinstead [:bgrins]]

It appears that RTL is broken (via `./mach run --temp-profile --setpref intl.uidirection=1`), which sort of makes sense since we'll need to set the [dir] attribute: https://searchfox.org/mozilla-central/rev/1ce4e8a5601da8e744ca6eda69e782318afab54d/browser/base/content/aboutNetError-new.xhtml#30.

Comment 2

[Brian Grinstead [:bgrins]]

XULDocument looks up RTL at: https://searchfox.org/mozilla-central/rev/fc3d974254660b34638b2af9d5431618b191b233/dom/xul/XULDocument.cpp#1843

Comment 3

[Patrick Brosset <:pbro>]

This bug has not been updated in the last 3 months. Resetting the assignee field.
Please, feel free to pick it up again and add a comment outlining your plans for it if you do still intend to work on it.
This is just trying to clean our backlog of bugs and make bugs available for people.

Comment 4

[Brendan Dahl [:bdahl]]

Attachment: Bug 1498287 - Support RTL pref in non-XUL documents too. r=smaug

Moves most of the RTL handling from XULDocument into Document. Creates
a new static class that listens to the direction pref change and notifies
all the documents when it changes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/956f2266fdfb
Support RTL pref in non-XUL documents too. r=smaug

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/956f2266fdfb