1498331 - EventEmitter.off doesn't support being called with more than 3 arguments

Status: RESOLVED FIXED

(DevTools :: General, enhancement)

Description

[Julien Wajsberg [:julienw]]

I noticed this issue while working on the tests for the old performance panel: the event handlers are not removed where they should, because there's some generic code that calls `off` with 3 arguments (which translates to 4 arguments when the static method is called). Because of this the event handler is never removed.

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: Bug 1498331 - Supports the case where EventEmitter.off is called with more than 3 arguments

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: Bug 1498331 - Supports the case where EventEmitter.off is called with more than 3 arguments

Comment 3

[Julien Wajsberg [:julienw]]

Try is https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e9125522b0057e51f738da10916a78792065fa3

Comment 4

[Julien Wajsberg [:julienw]]

I checked that the new test fails on central.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00388a3697f1
Supports the case where EventEmitter.off is called with more than 3 arguments r=jdescottes

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/00388a3697f1