Closed Bug 1498331 Opened 2 years ago Closed 2 years ago

EventEmitter.off doesn't support being called with more than 3 arguments

Categories

(DevTools :: General, enhancement)

enhancement
Not set
normal

Tracking

(firefox64 fixed)

RESOLVED FIXED
Firefox 64
Tracking Status
firefox64 --- fixed

People

(Reporter: julienw, Assigned: julienw)

Details

Attachments

(1 file, 1 obsolete file)

I noticed this issue while working on the tests for the old performance panel: the event handlers are not removed where they should, because there's some generic code that calls `off` with 3 arguments (which translates to 4 arguments when the static method is called). Because of this the event handler is never removed.
Attachment #9016417 - Attachment is obsolete: true
Assignee: nobody → felash
I checked that the new test fails on central.
Pushed by jwajsberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00388a3697f1
Supports the case where EventEmitter.off is called with more than 3 arguments r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/00388a3697f1
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.