EventEmitter.off doesn't support being called with more than 3 arguments

RESOLVED FIXED in Firefox 64

Status

enhancement
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: julienw, Assigned: julienw)

Tracking

unspecified
Firefox 64

Firefox Tracking Flags

(firefox64 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

8 months ago
I noticed this issue while working on the tests for the old performance panel: the event handlers are not removed where they should, because there's some generic code that calls `off` with 3 arguments (which translates to 4 arguments when the static method is called). Because of this the event handler is never removed.
Attachment #9016417 - Attachment is obsolete: true
Assignee

Updated

8 months ago
Assignee: nobody → felash
Assignee

Comment 4

8 months ago
I checked that the new test fails on central.

Comment 5

8 months ago
Pushed by jwajsberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/00388a3697f1
Supports the case where EventEmitter.off is called with more than 3 arguments r=jdescottes

Comment 6

8 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/00388a3697f1
Status: NEW → RESOLVED
Last Resolved: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.