Closed
Bug 1498331
Opened 6 years ago
Closed 6 years ago
EventEmitter.off doesn't support being called with more than 3 arguments
Categories
(DevTools :: General, enhancement)
DevTools
General
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: julienw, Assigned: julienw)
Details
Attachments
(1 file, 1 obsolete file)
I noticed this issue while working on the tests for the old performance panel: the event handlers are not removed where they should, because there's some generic code that calls `off` with 3 arguments (which translates to 4 arguments when the static method is called). Because of this the event handler is never removed.
|
Assignee | |
Comment 1•6 years ago
|
||
|
|
Assignee | |
Comment 2•6 years ago
|
||
|
||
Updated•6 years ago
|
Attachment #9016417 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 3•6 years ago
|
||
Try is https://treeherder.mozilla.org/#/jobs?repo=try&revision=2e9125522b0057e51f738da10916a78792065fa3
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → felash
|
|
Assignee | |
Comment 4•6 years ago
|
||
I checked that the new test fails on central.
Pushed by jwajsberg@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/00388a3697f1 Supports the case where EventEmitter.off is called with more than 3 arguments r=jdescottes
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/00388a3697f1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•