Closed Bug 1498368 Opened Last year Closed Last year

[wpt-sync] Sync PR 13469 - [css-properties-values-api] Avoid viewport dependent tests.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 13469 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/13469
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:
>  [css-properties-values-api] Avoid viewport dependent tests.
>  
>  The test registered-property-computation.html fails on wpt.fyi, because
>  it assumes that the tests are run in a viewport with specific dimensions.
>  
>  This CL fixes that by using a standard property as a reference. For
>  instance, to figure out the expected value in pixels for '10vw', we
>  compute min-height:10vw and use that result as the expected value.
>  
>  Also added some generally useful utils, and rewrote the test using those
>  utils to make the test more understandable.
>  
>  R=futhark@chromium.org
>  
>  Bug: 641877
>  Change-Id: Ie1ceb334eefee6e76015447f24148638ad8c55a6
>  Reviewed-on: https://chromium-review.googlesource.com/1275893
>  WPT-Export-Revision: 64ba6b9dfa5446e79b271d9763d4cb6357752109
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 2 tests and 16 subtests
OK     : 2
FAIL   : 16

New tests that have failures or other problems:
/css/css-properties-values-api/self-utils.html
    Default initial values of generated properties are valid (self-test).: FAIL
    Generated properties respect inherits flag: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/92bf8a8afc4e
[wpt PR 13469] - [css-properties-values-api] Avoid viewport dependent tests., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6cefa08ec89
[wpt PR 13469] - Update wpt metadata, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/052a4647bc04
[wpt PR 13469] - [css-properties-values-api] Avoid viewport dependent tests., a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/483aee01b7d1
[wpt PR 13469] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/052a4647bc04
https://hg.mozilla.org/mozilla-central/rev/483aee01b7d1
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.