1498369 - Propagate the user interaction flag through the resolve handler of the promise returned from hasStorageAccess as well

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[(no longer active)]

In addition to bug 1491403, there is another case for us to handle, I think.  What if someone has code like this:

onclick="foo()"

function foo() {
  document.hasStorageAccess()
          .then(success => {
            if (!success) {
              return document.requestStorageAccess();
            }
           });
}

In this case, the call to requestStorageAccess() will break because the resolve handler will have lost the user interaction flag by the time that it runs.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

All this stuff depends on the user activation model we want. Google is proposing the very simple model, but I'm not sure how well that will work.
https://mustaqahmed.github.io/user-activation-v2/ is some version of that.

Comment 2

[(no longer active)]

Yes indeed.  Note that this is just an extension of the special hack we're adding for the storage access API while a general solution is being figured out.

Comment 3

[(no longer active)]

Attachment: Bug 1498369 - Ensure the promise returned from Document.hasStorageAccess() will propagate user activation

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a58c07d9a7fa
Ensure the promise returned from Document.hasStorageAccess() will propagate user activation r=baku

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/a58c07d9a7fa