1498383 - [wdspec] clear.py relies on old Gecko's <button> hit testing

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

test_button_with_subtree seems to rely on the old behavior

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: clear.py_button_export.diff

Comment 2

[Andreas Tolfsen ❲:ato❳]

Comment on attachment 9016587 [details] [diff] [review]
clear.py_button_export.diff

Review of attachment 9016587 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Olli!

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Interesting that no other browser vendor, and I assume have already implemented that behavior, has complaint about this test yet.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Hmm, this test gets run on all the browsers?
The test is basically data:text/html,<button><input value=foobar></button> and
one is supposed to be able to use that input element. And can in current Chrome, and in FF with the patch for bug 1089326

Comment 5

[Andreas Tolfsen ❲:ato❳]

If it’s of any help, it looks like other vendors run
test_button_with_subtree but that the test in its current state is
failing for them:
https://wpt.fyi/results/webdriver/tests/element_clear/clear.py?label=experimental

I suppose we will get the real answer to whether or not they implement
the correct behaviour when this patch lands, and wpt.fyi does another
overnight test run.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Yes, that is indeed correct. Lets see how this changes when the patch landed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7029e8b4d7d0
clear.py relies on old Gecko's <button> hit testing, r=ato

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/14477 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 10

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/7029e8b4d7d0

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged