1498417 - Don't manually black list other vendors from WebRender

Status: VERIFIED FIXED

(Core :: Graphics: WebRender, defect, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

We have a check for nvidia here:
https://searchfox.org/mozilla-central/rev/1ce4e8a5601da8e744ca6eda69e782318afab54d/gfx/thebes/gfxPlatform.cpp#2716

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1498417. Don't manually black list other vendors from WebRender

We have a check for nvidia here:
https://searchfox.org/mozilla-central/rev/1ce4e8a5601da8e744ca6eda69e782318afab54d/gfx/thebes/gfxPlatform.cpp#2716

Comment 2

[Kartikaya Gupta (email:[e-mail])]

This never landed, but we should land it. Stealing.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1498417 - Don't manually blacklist non-nVidia drivers from WebRender. r?mattwoodrow

We already have a check for the nvidia vendor id in gfxPlatform.cpp so
we don't need to list all the other vendors explicitly.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Try push including the updated patch is at https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=0c3fafc770390e3b83ce12cb9d58a2d443b355b3

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b0d0d3516bc
Don't manually blacklist non-nVidia drivers from WebRender. r=mattwoodrow

Comment 6

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3b0d0d3516bc

Comment 7

[Julien Cristau [:jcristau] (back August 18)]

Mind requesting release uplift?  This is a dependency for bug 1501533.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 9019765 [details]
Bug 1498417 - Don't manually blacklist non-nVidia drivers from WebRender. r?mattwoodrow

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: none

User impact if declined: No user visible impact, but we want this as a dependency for uplifting bug 1501533 to 64

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It's removing redundant code and has had lots of bake time so not really risky

String changes made/needed: none

Comment 9

[Rares Doghi, Desktop QA]

Hi, can someone provide the steps for this issue, its not exactly clear for us on how to test it, does this mean that Some other videocards other than Nvidia might also see the Webrender in about support if they set the gfx.webrender.all in about config ? 
Can someone help us verify this issue ?

Comment 10

[Kartikaya Gupta (email:[e-mail])]

This patch should be a "doesn't change anything" patch - it just cleans up some code. The code being modified ensures that if you set gfx.webrender.all.qualified to true, only NVidia cards will get WebRender enabled. So you could e.g. test with a modern NVidia card and say an Intel or AMD card, set gfx.webrender.all.qualified to true, and ensure that the behaviour with this patch is the same as the behaviour without the patch (you should get WR enabled in about:support with the NVidia card, assuming you meet the other qualification criteria, but not with the AMD/Intel card).

Comment 11

[Rares Doghi, Desktop QA]

Based on Comment 10 and the fact that we tested this issue on Windows 10 using Nightly 65.0a1 (2018-12-06) with and Without NVIDIA cards, we can mark this issue as verified since The WebRender is correctly recognized on Nvidia cards in about:support.

Comment 12

[Julien Cristau [:jcristau] (back August 18)]

Comment on attachment 9019765 [details]
Bug 1498417 - Don't manually blacklist non-nVidia drivers from WebRender. r?mattwoodrow

included in 64.0 rc2, thanks

Comment 13

[Julien Cristau [:jcristau] (back August 18)]

https://hg.mozilla.org/releases/mozilla-release/rev/c0b34e542973

Comment 14

[Rares Doghi, Desktop QA]

I have re-tested this issue on firefox Beta 65.0b2 and i can confirm it as fixed. WebRender is displayed correctly in about:support on Windows 10 with Nvidia cards, but its not displayed on Other VGA cards. I will mark this issue accordingly.

Comment 15

[Julien Cristau [:jcristau] (back August 18)]

If you tested on 65.0b2 did you flip the 64 status flag on purpose?

Comment 16

[Rares Doghi, Desktop QA]

Hi, I tested this issue on Nightly 65.0a1 and I grab The Beta build from here https://tools.taskcluster.net/index/gecko.v2.mozilla-beta.latest.firefox/win64-opt, I thought that was the latest beta build that we should test this on and that was the coresponding flag for Beta 64, in case I was mistaken I also tested the Build from https://tools.taskcluster.net/index/gecko.v2.mozilla-release.latest.firefox/win64-opt which is 64.0 id 20181210010320 and Its Confirmed as fixed there as well.

Please let me know if I should change any flags back to fixed and sorry for the confusion.

Comment 17

[Julien Cristau [:jcristau] (back August 18)]

Sounds good, thanks.