1498478 - Turn on pocket personalization v2 by default in nightly

Status: RESOLVED FIXED

(Firefox :: New Tab Page, enhancement, P2)

Description

[Ed Lee :Mardak]

I checked talos and perhaps not surprisingly, there were no significant regressions https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=ef541339656f4fa816e45f22b1b6513eb8975978&newProject=try&newRevision=71e058ecf823822e030a776b530276c54377de32&framework=1

Not sure if it's because remote settings / network is turned off anyway.

What will happen for actual users where network connections are allowed but remote settings bucket doesn't exist? Is turning on v2 by default in nightly 64 blocked on buckets?

For setting a pref for nightly users, would reusing CFR's channel check work? Are there issues with shield study?

https://github.com/mozilla/activity-stream/blob/87eccdede902211fb63e6e39b65bc7ecc1e2100b/lib/ActivityStream.jsm#L46

version: IS_NIGHTLY_OR_UNBRANDED_BUILD ? 2 : 1

Comment 1

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4495

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/8f6ea4ffc3281e8cb3aac9d229dec5b4b8898548
Fix Bug 1498478 - Turn on pocket personalization v2 by default in nightly (#4495)

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/a58d921ba5a1