Closed Bug 1498489 Opened Last year Closed Last year
Remove redundant `virtual` from final virtual function declarations
47 bytes, text/x-phabricator-request
|Details | Review|
No description provided.
Follow up of bug 1436263
Attachment #9016621 - Attachment description: bug 1498489 - Remove `virtual` from final virtual function declarations r?froydnj → bug 1498489 - Remove `final` from final virtual function declarations r?froydnj
Why do we remove `final` even though it is a final method? Why isn't `virtual` removed instead?
As you wish :) I was trying to fix some linting issue.
Reassigning, Chris knows much more than I do on that :)
Assignee: nobody → cpeterson
Anthony - is there a better component for this kind of thing?
Unassigning myself because I don't have time to work on this. The cpp-virtual-final.yml lint check added in bug 1436263 warns about virtual functions that redundantly specify `virtual`, `override`, and/or `final` (though only for function declarations that fit on one line). This bug is about cleaning up multi-line virtual function declarations.
Source code analysis is probably a better component for this bug.
Component: General → Source Code Analysis
Product: Core → Firefox Build System
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/45d4f9eb3c21 Remove `virtual` from the declaration of an already virtual function. r=froydnj
reset the owner for a test.
Assignee: bpostelnicu → nobody
Assignee: nobody → bpostelnicu
Why am I removed from the CC list?
Because I was experimenting with this bug and didn't want to flood you with my trials.
You need to log in before you can comment on or make changes to this bug.