1498489 - Remove redundant `virtual` from final virtual function declarations

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement, P5)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: bug 1498489 - Remove `final` from final virtual function declarations r?froydnj

Follow up of bug 1436263

Comment 2

[Masatoshi Kimura [:emk]]

Why do we remove `final` even though it is a final method? Why isn't `virtual` removed instead?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

As you wish :)
I was trying to fix some linting issue.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Reassigning, Chris knows much more than I do on that :)

Comment 5

[Selena Deckelmann :selenamarie :selena]

Anthony - is there a better component for this kind of thing?

Comment 6

[Chris Peterson [:cpeterson]]

Unassigning myself because I don't have time to work on this.

The cpp-virtual-final.yml lint check added in bug 1436263 warns about virtual functions that redundantly specify `virtual`, `override`, and/or `final` (though only for function declarations that fit on one line). This bug is about cleaning up multi-line virtual function declarations.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Source code analysis is probably a better component for this bug.

Comment 8

[Andi [:andi]]

Attachment: Bug 1498489 - Remove `virtual` from the declaration of an already virtual function. r?froydnj

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45d4f9eb3c21
Remove `virtual` from the declaration of an already virtual function. r=froydnj

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/45d4f9eb3c21

Comment 11

[Sylvestre Ledru [:Sylvestre]]

reset the owner for a test.

Comment 12

[Masatoshi Kimura [:emk]]

Why am I removed from the CC list?

Comment 13

[Sylvestre Ledru [:Sylvestre]]

Because I was experimenting with this bug and didn't want to flood you with my trials.