Closed Bug 1498489 Opened 5 years ago Closed 5 years ago

Remove redundant `virtual` from final virtual function declarations

Categories

(Developer Infrastructure :: Source Code Analysis, enhancement, P5)

Product:
Developer Infrastructure
Component:
Source Code Analysis
Type:
enhancement

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: Sylvestre, Assigned: andi)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1498489 - Remove `virtual` from the declaration of an already virtual function. r?froydnj
47 bytes, text/x-phabricator-request
Details | Review 
      No description provided.
Attachment #9016621 - Attachment description: bug 1498489 - Remove `virtual` from final virtual function declarations r?froydnj → bug 1498489 - Remove `final` from final virtual function declarations r?froydnj
Why do we remove `final` even though it is a final method? Why isn't `virtual` removed instead?
Flags: needinfo?(sledru)
As you wish :)
I was trying to fix some linting issue.
Flags: needinfo?(sledru)
Reassigning, Chris knows much more than I do on that :)
Assignee: nobody → cpeterson
Anthony - is there a better component for this kind of thing?
Flags: needinfo?(ajones)
Unassigning myself because I don't have time to work on this.

The cpp-virtual-final.yml lint check added in bug 1436263 warns about virtual functions that redundantly specify `virtual`, `override`, and/or `final` (though only for function declarations that fit on one line). This bug is about cleaning up multi-line virtual function declarations.
Assignee: cpeterson → nobody
status-firefox64: affected → ---
Priority: -- → P5
Summary: Followup Remove `virtual` from final virtual function declarations → Remove redundant `virtual` from final virtual function declarations
Assignee: nobody → bpostelnicu
Source code analysis is probably a better component for this bug.
Component: General → Source Code Analysis
Flags: needinfo?(ajones)
Product: Core → Firefox Build System
Pushed by bpostelnicu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45d4f9eb3c21
Remove `virtual` from the declaration of an already virtual function. r=froydnj
https://hg.mozilla.org/mozilla-central/rev/45d4f9eb3c21
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
reset the owner for a test.
Assignee: bpostelnicu → nobody
Assignee: nobody → bpostelnicu
Assignee: bpostelnicu → nobody
Assignee: nobody → bpostelnicu
Why am I removed from the CC list?
Flags: needinfo?(sledru)
Because I was experimenting with this bug and didn't want to flood you with my trials.
Flags: needinfo?(sledru)
Attachment #9016621 - Attachment is obsolete: true
Blocks: clang-format
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.