Closed Bug 1498572 Opened 6 years ago Closed 6 years ago

Remove eval from harness.xul

Categories

(Core :: DOM: Security, enhancement, P3)

Product:
Core
Component:
DOM: Security
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: vinoth, Assigned: vinoth)

References

(Blocks 1 open bug)

Details

(Whiteboard: [domsecurity-backlog1])

Attachments

(1 file)

Bug 1498572 - Remove eval from harness.xul
46 bytes, text/x-phabricator-request
ckerschb
: review+
Details | Review
Eval(), new Function() should never execute with system principal.It is being removed everywhere from our codebase as part of Bug 1473549. The affected code which should be rewritten, https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/testing/mochitest/harness.xul#51
Component: Mochitest → DOM: Security
Product: Testing → Core
Version: Version 3 → unspecified
Whiteboard: [domsecurity-backlog1]
Assignee: nobody → cegvinoth
Comment on attachment 9019020 [details] Bug 1498572 - Remove eval from harness.xul Please kindly review the patch and let me know if changes are needed. Corresponding TRY push for this patch is, https://treeherder.mozilla.org/#/jobs?repo=try&revision=471f14cb23e9edd966f120928ff61f422b7df11a&selectedJob=206979515
Attachment #9019020 - Flags: review?(ckerschb)
Comment on attachment 9019020 [details] Bug 1498572 - Remove eval from harness.xul As mentioned in Phabricator, if that works I am fine with it. thanks!
Attachment #9019020 - Flags: review?(ckerschb) → review+
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6615d7dcdec1 Remove eval from harness.xul r=ckerschb
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6615d7dcdec1
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: